[Bug]: new app menu for Nextcloud 34: don't show "app store"-button for normal users

[schiessle]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Normal users see a "app store" button on the new apps menu pointing to apps.nextcloud.com

Steps to reproduce

1. Open the new apps menu as normal user

Expected behavior

For addmins I think it makes sense having a "add additional apps" button which should lead directly to the app management within Nextcloud. Regular users should just see the existing app, otherwise it is quite confusing because it creates the impression that they could download and add apps somehow to their account.

Nextcloud Server version

34

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

[joshtrichards]

Looks like it wasn't originally in there, but was added in a later follow-up commit (8e5d02b) deliberately (near the end of the #60180 review cycle).

I tend to agree it shouldn't be visible as it'll create confusion and isn't an operation a non-admin can do anything with.

[pringelmann]

Yes this was specifically requested, but will remove it until we find a better solution

[jancborchardt]

For reference: #59888 (comment)

It should not be straight up removed, but can just be hidden by default in the enterprise version. It's very useful for people to know that there are many more apps available. :)

[pringelmann]

I will remove it for 34 then and add enterprise checking in next minor release