Skip to content

feat: remove password column from user table#59348

Merged
artonge merged 1 commit intonextcloud:masterfrom
mykh-hailo:feat/ui-enhancement
Apr 9, 2026
Merged

feat: remove password column from user table#59348
artonge merged 1 commit intonextcloud:masterfrom
mykh-hailo:feat/ui-enhancement

Conversation

@mykh-hailo
Copy link
Copy Markdown
Contributor

@mykh-hailo mykh-hailo commented Mar 31, 2026 •
edited by artonge
Loading

Summary

his PR improves the Users table by removing the password column while expanding the Groups column for better readability.

Before After
image image

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@mykh-hailo mykh-hailo requested review from a team and skjnldsv as code owners March 31, 2026 11:14
@mykh-hailo mykh-hailo requested review from nfebe and sorbaugh and removed request for a team March 31, 2026 11:14
@mykh-hailo mykh-hailo force-pushed the feat/ui-enhancement branch from 5040fd5 to e48f34e Compare March 31, 2026 11:15
@joshtrichards
Copy link
Copy Markdown
Member

joshtrichards commented Mar 31, 2026

@mykh-hailo First, thanks. Second, any chance you can split this up into two PRs? These two matters seem unrelated to each other. ;-)

@mykh-hailo mykh-hailo force-pushed the feat/ui-enhancement branch from e48f34e to de31ed7 Compare March 31, 2026 17:01
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

mykh-hailo commented Mar 31, 2026

@joshtrichards Thanks for the feedback.
I updated this branch for removing password column from user table.
I'd appreciate it if you review it again.

@mykh-hailo mykh-hailo changed the title Feat/UI enhancement feat: remove password column from user table Mar 31, 2026
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

mykh-hailo commented Apr 6, 2026

@susnux , @joshtrichards
I'd appreciate it if you give me any feedback on this PR.
Thank you.

@susnux susnux requested review from artonge and pringelmann and removed request for nfebe and sorbaugh April 6, 2026 21:00
@susnux
Copy link
Copy Markdown
Contributor

susnux commented Apr 6, 2026

@mykh-hailo better to align with @nextcloud/designers also requested @pringelmann as he is reworking the account management currently.

@susnux susnux added team: IDP Code maintained by 🪪 IDP team enhancement and removed feature: files labels Apr 6, 2026
@susnux susnux added this to the Nextcloud 34 milestone Apr 6, 2026
@mykh-hailo mykh-hailo force-pushed the feat/ui-enhancement branch 3 times, most recently from 61acf75 to a208b40 Compare April 7, 2026 13:58
@artonge
Copy link
Copy Markdown
Collaborator

artonge commented Apr 7, 2026

Thank you for the proposal @mykh-hailo. Can you add some before/after screenshots to the main comment?

@mykh-hailo
Copy link
Copy Markdown
Contributor Author

mykh-hailo commented Apr 7, 2026

@artonge Here is the screenshots for my update.

Before After
image image

@mykh-hailo mykh-hailo force-pushed the feat/ui-enhancement branch from a208b40 to b64291e Compare April 7, 2026 16:03
artonge
artonge approved these changes Apr 7, 2026
View reviewed changes
apps/settings/src/components/Users/shared/styles.scss Outdated
*/

@mixin row {
@mixin row {
Copy link
Copy Markdown
Collaborator

@artonge artonge Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected white space change?

@artonge
Copy link
Copy Markdown
Collaborator

artonge commented Apr 8, 2026

Looks good @mykh-hailo.

  1. Can you look into fixing the failing eslint CI job?
  2. Can you address the last pending comment?
  3. Can you squash your commits, and include the build files?

@mykh-hailo mykh-hailo force-pushed the feat/ui-enhancement branch from 11c21b0 to 4118a75 Compare April 8, 2026 13:58
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

mykh-hailo commented Apr 8, 2026

@artonge I update the code for you comment.
Could you please check it again?

@artonge
Copy link
Copy Markdown
Collaborator

artonge commented Apr 8, 2026

@mykh-hailo looks like the build files are not up to date. Be sure to update your node_modules folder with npm ci

@mykh-hailo mykh-hailo force-pushed the feat/ui-enhancement branch from 4118a75 to 0ce2e0f Compare April 8, 2026 15:04
@artonge artonge enabled auto-merge April 8, 2026 15:47
@mykh-hailo
feat: remove password column from user table
415ecb1 
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
auto-merge was automatically disabled April 8, 2026 16:04

Head branch was pushed to by a user without write access

@mykh-hailo mykh-hailo force-pushed the feat/ui-enhancement branch from 0ce2e0f to 415ecb1 Compare April 8, 2026 16:04
@mykh-hailo
Copy link
Copy Markdown
Contributor Author

mykh-hailo commented Apr 9, 2026

Hi @artonge , Could you possibly give me the ETA for this PR?

@artonge artonge merged commit e3e499a into nextcloud:master Apr 9, 2026
143 of 147 checks passed
@artonge
Copy link
Copy Markdown
Collaborator

artonge commented Apr 9, 2026

Thank you for the submission @mykh-hailo ! And thank you for reacting so quickly to our comments :)

@mykh-hailo
Copy link
Copy Markdown
Contributor Author

mykh-hailo commented Apr 9, 2026

@artonge Sorry for the off-topic message here.

Could you please check my another PRs for nextcloud server as well?
It's been a week since the PRs are created but still no approves and comments there.
I'd appreciate it if you help me to merge the PRs asap.

#59465
#59359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@pringelmann pringelmann pringelmann approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement feature: users and groups team: IDP Code maintained by 🪪 IDP team

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

Remove password column, widen groups column

6 participants

@mykh-hailo @joshtrichards @susnux @artonge @pringelmann @skjnldsv