Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layout of sharing sidebar #48925

Open
marcoambrosini opened this issue Oct 28, 2024 · 4 comments · May be fixed by #50282
Open

Improve layout of sharing sidebar #48925

marcoambrosini opened this issue Oct 28, 2024 · 4 comments · May be fixed by #50282

Comments

@marcoambrosini
Copy link
Member

Here's a mock up of the layout changes proposed for the sharing sideber. The main idea is to separate between internal and external shares.

Image

@marcoambrosini marcoambrosini self-assigned this Oct 28, 2024
@marcoambrosini marcoambrosini converted this from a draft issue Oct 28, 2024
@marcoambrosini marcoambrosini moved this from 📐 At design to 🏗️ At engineering in 🖍 Design team Oct 28, 2024
@marcoambrosini marcoambrosini added this to the Nextcloud 31 milestone Oct 28, 2024
@sorbaugh sorbaugh moved this to 📄 To do (~10 entries) in 📁 Files team Nov 29, 2024
@sorbaugh
Copy link
Contributor

sorbaugh commented Dec 3, 2024

@marcoambrosini this topic is currently up to date?

@marcoambrosini
Copy link
Member Author

Yes @sorbaugh this is current

@sorbaugh sorbaugh moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📁 Files team Dec 3, 2024
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 4, 2024
Primarily to move it out of the way for changes in the source location.

The feature was deprecated in version 25 (nextcloud#28320), five versions ago.

Refs: nextcloud#48925
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 4, 2024
According to screen designs.

* Elements and lists reordered
* Headlines and separators introduced

Intermediate step: components need to be dissolved in the following
commits.

Refs: nextcloud#48925
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 4, 2024
…are section

Allow share creation in the newly differentiated share section.

Intermediate change: to preserve functionality; this needs to be
differentiated with the next commits.

Refs: nextcloud#48925
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 4, 2024
…ringTab

According to nextcloud#48925 screen designs we've to split this into

1. Link (creation) and
2. List (of created share links)

Intermediate step.

Refs: nextcloud#48925
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 4, 2024
According to screen designs.

* Elements and lists reordered
* Headlines and separators introduced

Intermediate step: components need to be dissolved in the following
commits.

Refs: nextcloud#48925
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 4, 2024
…are section

Allow share creation in the newly differentiated share section.

Intermediate change: to preserve functionality; this needs to be
differentiated with the next commits.

Refs: nextcloud#48925
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 4, 2024
…ringTab

According to nextcloud#48925 screen designs we've to split this into

1. Link (creation) and
2. List (of created share links)

Intermediate step.

Refs: nextcloud#48925
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 5, 2024
Primarily to move it out of the way for changes in the source location.

The feature was deprecated in version 25 (nextcloud#28320), five versions ago.

Refs: nextcloud#48925
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 5, 2024
According to screen designs.

* Elements and lists reordered
* Headlines and separators introduced

Intermediate step: components need to be dissolved in the following
commits.

Refs: nextcloud#48925
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 5, 2024
…are section

Allow share creation in the newly differentiated share section.

Intermediate change: to preserve functionality; this needs to be
differentiated with the next commits.

Refs: nextcloud#48925
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 5, 2024
…ringTab

According to nextcloud#48925 screen designs we've to split this into

1. Link (creation) and
2. List (of created share links)

Intermediate step.

Refs: nextcloud#48925
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 5, 2024
…ringTab

According to nextcloud#48925 screen designs we've to split this into

1. Link (creation) and
2. List (of created share links)

Intermediate step.

Refs: nextcloud#48925
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 6, 2024
shareWith is below used _trimmed_ to index the field of the
shareWith-to-type mapping; thus, create the key trimmed too.

Why trimming is done here is questionable though.

Refs: nextcloud#48925

Signed-off-by: Thomas Lehmann <[email protected]>
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 6, 2024
flat() is speaking

Support is good: https://caniuse.com/array-flat

Refs: nextcloud#48925

Signed-off-by: Thomas Lehmann <[email protected]>
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 6, 2024
Encapsulate the share type differntiation/grouping in one module.

Refs: nextcloud#48925

Signed-off-by: Thomas Lehmann <[email protected]>
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 6, 2024
Inspired (initially copied) from SearchInput, implemented to search only
for external (remote) sharees.

WIP: changes and further TODOs mentioned in the comments at the
beginning of the file

Refs: nextcloud#48925

Signed-off-by: Thomas Lehmann <[email protected]>
thlehmann-ionos added a commit to IONOS-Productivity/nc-server that referenced this issue Dec 6, 2024
Change SharingInput to search for internal share types only.

* Lookup was removed because we don't want to lookup users for
  internal shares
* The global lookup entry is no longer added to the end of the
  list for the same reason
* Share types are limited to internal shares
* Placeholder texts are adapted

Refs: nextcloud#48925

Signed-off-by: Thomas Lehmann <[email protected]>
@tobiasKaminsky
Copy link
Member

@marcoambrosini clients also started working on it.
What is the blue "i" about? Clicking on it should show a tooltip, with which content?

@marcoambrosini
Copy link
Member Author

Hi @tobiasKaminsky, I would say:

  • Use internal shares to share with people who have an account in this organization.
  • Use external shares to share with people who don't have an account in this organization.

nfebe pushed a commit that referenced this issue Jan 20, 2025
Primarily to move it out of the way for changes in the source location.

The feature was deprecated in version 25 (#28320), five versions ago.

Refs: #48925
nfebe pushed a commit that referenced this issue Jan 20, 2025
According to screen designs.

* Elements and lists reordered
* Headlines and separators introduced

Intermediate step: components need to be dissolved in the following
commits.

Refs: #48925
nfebe pushed a commit that referenced this issue Jan 20, 2025
…are section

Allow share creation in the newly differentiated share section.

Intermediate change: to preserve functionality; this needs to be
differentiated with the next commits.

Refs: #48925
nfebe pushed a commit that referenced this issue Jan 20, 2025
…ringTab

According to #48925 screen designs we've to split this into

1. Link (creation) and
2. List (of created share links)

Intermediate step.

Refs: #48925
@nfebe nfebe linked a pull request Jan 20, 2025 that will close this issue
8 tasks
nfebe pushed a commit that referenced this issue Jan 21, 2025
Primarily to move it out of the way for changes in the source location.

The feature was deprecated in version 25 (#28320), five versions ago.

Refs: #48925
nfebe pushed a commit that referenced this issue Jan 22, 2025
Primarily to move it out of the way for changes in the source location.

The feature was deprecated in version 25 (#28320), five versions ago.

Refs: #48925
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ In progress
Status: 🏗️ At engineering
4 participants