Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: system e-mail and occ broken after upgrade from NC28 to 30.0.4 (docker) via NC29 #50029

Open
5 of 8 tasks
dora71 opened this issue Jan 3, 2025 · 3 comments
Open
5 of 8 tasks
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug needs info

Comments

@dora71
Copy link

dora71 commented Jan 3, 2025

⚠️ This issue respects the following points: ⚠️

Bug description

Trying to call the occ command results in an exception, see "Steps to reproduce", regardless what occ command is executed
Also, system eMail check is not possible (just a red box with "sending ..." nothing happens, but exception is same as executing the occ command).
Mail and occ worked fine with NC28 (also docker image), exception occured after upgrade to NC30 via NC29. If exception was already on NC29, I don't know, just upgraded the docker image.

My system data:

  • selfhosted (PC with debian 11.11 and Nextcloud Community docker image)
  • Nextcloud Version: 30.0.4 (in docker)
  • PHP Version: PHP 8.2.27 (in docker)
  • MariaDB 10.5.26-MariaDB-0+deb11u2 Debian 11 (on host System)
  • Apache version 2.4.62 (as reverse proxy)

Steps to reproduce

  1. Open a terminal and execute docker exec -i --user www-data nextcloud php occ
  2. Exception is thrown immediately (see Nextcloud logs, eMail address blurred with my.name)

Expected behavior

  • Executing the occ command with docker exec -i --user www-data nextcloud php occ should open available options from occ
  • Verifying the system's e-mail settings should result in success or error

Nextcloud Server version

30

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 28 to 29)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

not possible as occ is broken

List of activated Apps

not possible as occ is broken

Nextcloud Signing status

Technical information
=====================
The following list covers which files have failed the integrity check. Please read
the previous linked documentation to learn more about the errors and how to fix
them.

Results
=======
- core
	- EXTRA_FILE
		- tmp/sess_47f5a82490bcab8c75411cf2273b28ec
		- tmp/sess_aaf9c37f33bf8461cfc54ec4aa18e70d
		- tmp/sess_14b0aa280d579455c75b64098480d1a6
		- tmp/sess_4ffea40cba3e44f88db1ef4626dfc36e
		- tmp/sess_fcf21fb066214f9148f6c5e4677e4c84
		- tmp/sess_999161a10fd781fc39767164888984a3
		- tmp/sess_75ba6ab2f156ab6dd5ea592955c39dc4
		- tmp/sess_72c976dc13c0953571fca05176a296ae
		- tmp/sess_a816920aaeba14c54cb05067affaa977
		- tmp/sess_01c5a220216b7a7d81151713b7130e96
		- tmp/sess_338f7fc808513bc39fc33da33b98aaba
		- tmp/sess_152b5fb766cf7de38753e7025916d74a
		- tmp/sess_26b740ea4788e124dcb20f8383ab0b44
		- tmp/sess_d74df726e08e1d4d46d215adefed25c8
		- tmp/sess_d8f387560e30777196349cfa8993df84
		- tmp/sess_9c64dbed92c94e9d0a7d2acce1adc317
		- tmp/sess_f00e213bd22d73337f05a559af139727
		- tmp/sess_825c9a3befdf6773cd775afe8c0bb11f
		- tmp/sess_8b3eeda636d0a18566f954b656d0aa88
		- tmp/sess_1b8a8e653c49d6b6b251d2b2134a0de1
		- tmp/sess_34bcc3ec721c20b5743b4a2b279d7ff5
		- tmp/sess_6e7edb6a437d9d7e6ab83b4c75a56d5d
		- tmp/sess_6e6eaa579fddc4692637d97967b1e670
		- tmp/sess_e9368a94dc819c9c979855353523d59c
		- tmp/sess_de4641d19b43376ef6d807dfd0cd8232

Raw output
==========
Array
(
    [core] => Array
        (
            [EXTRA_FILE] => Array
                (
                    [tmp/sess_47f5a82490bcab8c75411cf2273b28ec] => Array
                        (
                            [expected] => 
                            [current] => eaa0e643576221179456462698348152373e21b75f6676a097721725ed2e3533d04957650acead792b1d81a89b9f40910f688a7fa6e9d1c11c2eb96742aec049
                        )

                    [tmp/sess_aaf9c37f33bf8461cfc54ec4aa18e70d] => Array
                        (
                            [expected] => 
                            [current] => a77431a05fda3d37535960f76063f027522de8f7ef3f4d0b6554a2b8669b0baf69328efc12a318c475ad6e17566bf3197626ac6d52bec2c39896a445ef6cfa88
                        )

                    [tmp/sess_14b0aa280d579455c75b64098480d1a6] => Array
                        (
                            [expected] => 
                            [current] => 442eeec8aff8c8019c6831deaca6419561b3bc48baa6795c695fc5c59a881ea9cee19b846361f9fef34bf0c3f183458a7bb7b49a90d4418cee5093ca2a2d6f4e
                        )

                    [tmp/sess_4ffea40cba3e44f88db1ef4626dfc36e] => Array
                        (
                            [expected] => 
                            [current] => b688f77777411ce8ae70a64679ba362ebb48ee4a9527c402c395f6b645799242bc8293c8d5a8c95911cbcb56fb957314dd84b9da00793055a6b855d67937a9cf
                        )

                    [tmp/sess_fcf21fb066214f9148f6c5e4677e4c84] => Array
                        (
                            [expected] => 
                            [current] => 5d7bb62de1f51b6e160d8e86547138a37fb14d9453a1062b43c76734db780a592105a6089a7435e3c6ebe4009bb8d3cd708487bc3a4703630b8ad5f242d1ae16
                        )

                    [tmp/sess_999161a10fd781fc39767164888984a3] => Array
                        (
                            [expected] => 
                            [current] => 84eadc3a97418161dee98bc0de551f87cba6d5f125dd139c7ad62d01d0472c367f1fd3111bc65c061ebe2c82dbcdece1d9772f89301aef3795ac057e78eaf639
                        )

                    [tmp/sess_75ba6ab2f156ab6dd5ea592955c39dc4] => Array
                        (
                            [expected] => 
                            [current] => 3d70da89c7c1cc2b1ac4602bc1924eb46ff04551f18e78ae5872f2803526f00684902705172454b4ad4532cc039261ab9db5829531008779ff08d3b808c449b2
                        )

                    [tmp/sess_72c976dc13c0953571fca05176a296ae] => Array
                        (
                            [expected] => 
                            [current] => 9b24dbe4e3889edf96d97204f7e6241fa38a571df59518468aa7086acdaa31191a79ad1e14528878dc4071f28dc043c04478cd4c3e420ad8f400a6e1461a87e6
                        )

                    [tmp/sess_a816920aaeba14c54cb05067affaa977] => Array
                        (
                            [expected] => 
                            [current] => 8b476a08eb0a59345b7258166be62a44f918eb0b4ac81e7141066cb1b11aeed9c663048b5b084c0a841ee1399d5a67db9c09b323d9f14fa032739c37c35ad092
                        )

                    [tmp/sess_01c5a220216b7a7d81151713b7130e96] => Array
                        (
                            [expected] => 
                            [current] => 0243bc3848aa2b225b1aea8a5fea8d37727d0a647f794010bf7e7f4b4948ad32f0bc002348881fbabfc2df57edc8e362a9a9ffafa0b56bdcffe1d9bec4d31c8c
                        )

                    [tmp/sess_338f7fc808513bc39fc33da33b98aaba] => Array
                        (
                            [expected] => 
                            [current] => 1a67f4c3a2666f8ead0e71335539b33420fd74b5d7179d48306e762241dc79f77ecece8a8c23a14e7df4f9544e99fcb3546e7ebeaeebbeb1a15caa8bce0cadae
                        )

                    [tmp/sess_152b5fb766cf7de38753e7025916d74a] => Array
                        (
                            [expected] => 
                            [current] => 4699539dbcea74e34e0b5566ef5d93ed96a1f95f75e782ecb8b557654acfcde4af222ed1466c7a82583f717f1d4856542a84cc01a7054258f7e47874ec54d741
                        )

                    [tmp/sess_26b740ea4788e124dcb20f8383ab0b44] => Array
                        (
                            [expected] => 
                            [current] => 0cdc3a181007b9edd67b5f00baf0a680abb527f9d7c7fbe8926008ec3e603c5b0ae4dd6f6be73aafb5ece622ccdd8f82ffb93bf126028300a967c07bd227aaa3
                        )

                    [tmp/sess_d74df726e08e1d4d46d215adefed25c8] => Array
                        (
                            [expected] => 
                            [current] => b7c731455a8854e1f48131017ffd853699541ee55fe474201d96d3cc8b0d3f7a690d2326cc1803652f61ccb90ed1eae1eddec9f4db9f43c2d0eef0440860f93a
                        )

                    [tmp/sess_d8f387560e30777196349cfa8993df84] => Array
                        (
                            [expected] => 
                            [current] => 6c40eecf1e8d2b8e738859678d5ba374776ccfe6e6ce43e0fe093b635e1e0810569fdd10a5e8044124b7c1e9d8e95c109cf6b08d01b39ff4ba3ef45be266723f
                        )

                    [tmp/sess_9c64dbed92c94e9d0a7d2acce1adc317] => Array
                        (
                            [expected] => 
                            [current] => 471119dc541b228f8655f13c1bafb2ecc0e2e09a6da48013bb79ae560af305f925dd19816dd67cdc2e183ef5f08d7400ce4ed5a2bd17594b2b5ea908b413c6cc
                        )

                    [tmp/sess_f00e213bd22d73337f05a559af139727] => Array
                        (
                            [expected] => 
                            [current] => 8c17d609d94354130f5aa9c654ab19b9baee6d70b2e095b6d3d6764ea4cbb86c9c0a9c84c12d45e42683c9d1b587d1a6e31314639a6768a4b17a7ec10b5751db
                        )

                    [tmp/sess_825c9a3befdf6773cd775afe8c0bb11f] => Array
                        (
                            [expected] => 
                            [current] => c9c78bd5553cfe9ae01a3a794ef3f7ea2b3de93408a875302584a09123685f702f81375449f6006421be7d0401e6fb488b93fc247298cd020836ae4a043f3102
                        )

                    [tmp/sess_8b3eeda636d0a18566f954b656d0aa88] => Array
                        (
                            [expected] => 
                            [current] => 75e4f431501e3d68f5a87f8616fa8109b9a89e4f7b59cb48f005efb0d503c14024c7246f5760ff9e2ede36eca7906847bf01b21762160319b0715981947ff576
                        )

                    [tmp/sess_1b8a8e653c49d6b6b251d2b2134a0de1] => Array
                        (
                            [expected] => 
                            [current] => f93ed2660449d08fc1e89e985c4488d7f138667d184cbc5a4217bfef5e5b1fba446825035e711c7cf171a73112e76bafb58cb4013ce93e4068ccda735fb0955e
                        )

                    [tmp/sess_34bcc3ec721c20b5743b4a2b279d7ff5] => Array
                        (
                            [expected] => 
                            [current] => efde9d052e90f32dd82d87f00374ca79e8c93842e45326f7b0aa63e27d51877237c2657d4532981ce0c50e915138aefb18f8cf35e8579cd5acb6b371667a3781
                        )

                    [tmp/sess_6e7edb6a437d9d7e6ab83b4c75a56d5d] => Array
                        (
                            [expected] => 
                            [current] => 7172d2094e80500b02fa4ba8773b82df85f3ac82a61b26ef813af45083e9873588ae23105ab0ff43a0440fa15f23975887f7413695179ec592d9e34c9e661754
                        )

                    [tmp/sess_6e6eaa579fddc4692637d97967b1e670] => Array
                        (
                            [expected] => 
                            [current] => 8118e2553c5344a1fe14b8ebd182874504374ddbe46e80bbfc83ccc761ebea1379f28767d4070b529fe95dbb4055017855009f7588a8d0068c0c10e1ae8b4c65
                        )

                    [tmp/sess_e9368a94dc819c9c979855353523d59c] => Array
                        (
                            [expected] => 
                            [current] => 3b4f593c05754e0d24b97fb78e74715138cb8ca4a6799cee5405168063aa94792d586abaf084007f900d41f96e12a129efd80e7cc12548620330b25d4f6bfa00
                        )

                    [tmp/sess_de4641d19b43376ef6d807dfd0cd8232] => Array
                        (
                            [expected] => 
                            [current] => 27c695518f1e9fa14b88f980c8b72420cca2359959d482dccb6224f5e2288a3a6b9703447898b9d17b520ff6ec8c5fb8d9352595118a847776d04e9f9a2ebafc
                        )

                )

        )

)

Nextcloud Logs

An unhandled exception has been thrown:
TypeError: Cannot assign array to property Egulias\EmailValidator\EmailLexer::$current of type Doctrine\Common\Lexer\Token in /var/www/html/3rdparty/egulias/email-validator/src/EmailLexer.php:211
Stack trace:
#0 /var/www/html/3rdparty/egulias/email-validator/src/Parser.php(74): Egulias\EmailValidator\EmailLexer->moveNext()
#1 /var/www/html/3rdparty/egulias/email-validator/src/EmailParser.php(38): Egulias\EmailValidator\Parser->hasAtToken()
#2 /var/www/html/3rdparty/egulias/email-validator/src/Parser.php(43): Egulias\EmailValidator\EmailParser->preLeftParsing()
#3 /var/www/html/3rdparty/egulias/email-validator/src/EmailParser.php(29): Egulias\EmailValidator\Parser->parse('my.name@gm...')
#4 /var/www/html/3rdparty/egulias/email-validator/src/Validation/RFCValidation.php(27): Egulias\EmailValidator\EmailParser->parse('my.name@gm...')
#5 /var/www/html/3rdparty/egulias/email-validator/src/Validation/NoRFCWarningsValidation.php(21): Egulias\EmailValidator\Validation\RFCValidation->isValid('my.name@gm...', Object(Egulias\EmailValidator\EmailLexer))
#6 /var/www/html/3rdparty/egulias/email-validator/src/EmailValidator.php(37): Egulias\EmailValidator\Validation\NoRFCWarningsValidation->isValid('my.name@gm...', Object(Egulias\EmailValidator\EmailLexer))
#7 /var/www/html/lib/private/Mail/Mailer.php(250): Egulias\EmailValidator\EmailValidator->isValid('my.name@gm...', Object(Egulias\EmailValidator\Validation\NoRFCWarningsValidation))
#8 /var/www/html/lib/public/Util.php(308): OC\Mail\Mailer->validateMailAddress('my.name@gm...')
#9 /var/www/html/apps/settings/lib/AppInfo/Application.php(166): OCP\Util::getDefaultEmailAddress('my.name')
#10 /var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php(153): OCA\Settings\AppInfo\Application->OCA\Settings\AppInfo\{closure}(Object(OC\AppFramework\DependencyInjection\DIContainer))
#11 /var/www/html/3rdparty/pimple/pimple/src/Pimple/Container.php(122): OC\AppFramework\Utility\SimpleContainer->OC\AppFramework\Utility\{closure}(Object(Pimple\Container))
#12 /var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php(120): Pimple\Container->offsetGet('OCA\\Settings\\Ma...')
#13 /var/www/html/lib/private/AppFramework/DependencyInjection/DIContainer.php(445): OC\AppFramework\Utility\SimpleContainer->query('OCA\\Settings\\Ma...')
#14 /var/www/html/lib/private/ServerContainer.php(137): OC\AppFramework\DependencyInjection\DIContainer->queryNoFallback('OCA\\Settings\\Ma...')
#15 /var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php(74): OC\ServerContainer->query('OCA\\Settings\\Ma...', true)
#16 [internal function]: OC\AppFramework\Utility\SimpleContainer->OC\AppFramework\Utility\{closure}(Object(ReflectionParameter))
#17 /var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php(61): array_map(Object(Closure), Array)
#18 /var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php(106): OC\AppFramework\Utility\SimpleContainer->buildClass(Object(ReflectionClass))
#19 /var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php(124): OC\AppFramework\Utility\SimpleContainer->resolve('OC\\Core\\Command...')
#20 /var/www/html/lib/private/ServerContainer.php(155): OC\AppFramework\Utility\SimpleContainer->query('OC\\Core\\Command...', true)
#21 /var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php(42): OC\ServerContainer->query('OC\\Core\\Command...')
#22 /var/www/html/lib/public/Server.php(39): OC\AppFramework\Utility\SimpleContainer->get('OC\\Core\\Command...')
#23 /var/www/html/core/register_command.php(109): OCP\Server::get('OC\\Core\\Command...')
#24 /var/www/html/lib/private/Console/Application.php(77): require_once('/var/www/html/c...')
#25 /var/www/html/console.php(81): OC\Console\Application->loadCommands(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#26 /var/www/html/occ(11): require_once('/var/www/html/c...')

Additional info

No response

@dora71 dora71 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jan 3, 2025
@kesselb
Copy link
Contributor

kesselb commented Jan 3, 2025

Hi,

OCP\Util::getDefaultEmailAddress('my.name')

Can you if the above is really 'my.name' in your stack trace? It should be no-reply according to the source.

It's a bit weird to see the occ command break. Can you share mail_from_address, mail_domain and the complete email address you are using? (the format is enough, no need to share the actual email but we need to know unusual things like special characters, whitespace, dots, domains without tld, etc ... anything that could make the valdiation "is that a valid email address" fail).

@dora71
Copy link
Author

dora71 commented Jan 3, 2025

@kesselb
just double-checked the stack trace, it is as I have written above.

here is my (anonymised) config:

  'mail_domain' => 'gmx.de',
  'mail_from_address' => 'my.name',

the (anonymised) mail address I use is [email protected]

but should this break the occ command as well as not being able to set the system eMail?

I also tried to set mail_from_address to no-reply, but it didn't change anything except the (expected) strace output:

#8 /var/www/html/lib/public/Util.php(308): OC\Mail\Mailer->validateMailAddress('[email protected]')
#9 /var/www/html/apps/settings/lib/AppInfo/Application.php(166): OCP\Util::getDefaultEmailAddress('no-reply')

@joshtrichards
Copy link
Member

It's likely a dependency overlap.

See nextcloud/suspicious_login#896 for a similar situation.

What apps do you have installed? (since you can't use occ the contents of both apps/ and custom_apps/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug needs info
Projects
None yet
Development

No branches or pull requests

4 participants