-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show expiration date on receiving shares #15819
Comments
For internal shares this should go into the sidebar right? For the public shares it should be at a similar location as the note already is or do you have a better idea? |
I was indeed thinking about user shares, like having a small calendar/time icon and a popup with the remaining time :) |
Would agree with @MorrisJobke this should go in the sidebar if anything. And for public shares it should also go into the to-be-added sidebar (for comments etc). |
Ah ok, you mean for the sender? In that case it should either be a subline (like the "Connect items to a project …" is for "Add to a project") or the icon should overlay the 3-dot menu so when you click, the relevant controls are opened. (Or both.) |
Nono, the mockup is wrong since it comes from the sender part, you're right. |
Awesome! 👍 |
This should then also be done on clients, or? |
Ideally yes |
I think it should either be |
BTW: how do you get the 18 days info? |
hm. This way we could omit a new query… |
@skjnldsv just nitpicks:
|
@jancborchardt fixed already (after the screenshot ;) ) |
Related: #15680 |
true ... where we can find the expiration date ? |
look at the content of the screenshot above |
yes, true, but would be more correct in propfind near
|
@skjnldsv the property is not available via dav file query, but only via share endpoint. |
@tobiasKaminsky that's a different issue ^^ |
Indeed: #16967 |
#15719 is merged, go go go Clients :D |
On the expiration date, we could show a message stating how many time is left.
The text was updated successfully, but these errors were encountered: