Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poll variant : Condorcet method support #3897

Open
1 task done
artlog opened this issue Mar 7, 2025 · 11 comments
Open
1 task done

poll variant : Condorcet method support #3897

artlog opened this issue Mar 7, 2025 · 11 comments

Comments

@artlog
Copy link

artlog commented Mar 7, 2025

⚠️ This issue respects the following points: ⚠️

Describe the goal you'd like to achieve

Support condorcet method in poll.

This method will require to set priorities or an ordering between poll entries.
Possibility to prioritize responses could be reused for other voting variant ( by example #3472 ).
This feature is part of voting variant and some requests exists already over this topic.

Describe possible solutions

I will start the study of this feature as mandated by my client.

Additional context

Astrolabe cooperative considers founding this request to get it done.

@dartcafe dartcafe added this to the backlog milestone Mar 7, 2025
@vinimoz
Copy link

vinimoz commented Mar 13, 2025

Hello, i was looking as well to get a feature like this one to be implement. I will look at it, i've found than php as already an library https://www.condorcet.io who can help. The easiest maybe it's have an option ranking in the text type poll configuration tab who let people insert text instead of checkbox.

@vinimoz
Copy link

vinimoz commented Mar 19, 2025

Hello Guys, i've implement the rank base poll with text only for the moment. I will do more test before to commit it. After, this implemented, i can try to work on condorcet with different vote result possibility. I saw u are working to migrate to vue3.... Hope it will not interfer too much. I've do my test with polls 7.4.1 Image

@dartcafe
Copy link
Collaborator

@vinimoz Nice. But please take into account, that the main branch is changing a lot.

The master-7 branch is the current branch for v7.x and will die once v8 is stable.

Would be happy to see your implementation and further discussion in your upcoming PR. If you need help, don't care to contact me. Let's see, how we can adopt it then for the main branch.

@vinimoz
Copy link

vinimoz commented Mar 23, 2025 via email

@vinimoz
Copy link

vinimoz commented Mar 23, 2025

after branch 8 is released what could be done :

  • Handled display, star vote ( *, **, ***, ) or appreciation vote ( bad, good, better )
  • Handle date rake poll vote.
  • Condorcet method could be apply as we can handle it with rank vote and the php library.

@dartcafe
Copy link
Collaborator

Since you are basing on 7.4.1, you can open a PR against the master-7 branch. I will then review it.

A PR does no harm.

@vinimoz
Copy link

vinimoz commented Mar 23, 2025

PR has been proceed, i've never done it hope it work. Let me know if u get it

@dartcafe
Copy link
Collaborator

Where? Not here...

Create a PR from your branch and point it to https://github.com/nextcloud/polls/tree/master-7

Image

@vinimoz
Copy link

vinimoz commented Mar 24, 2025

I think i've tried but i wasn't allowed, its look like i need to be a poll developer. So i do a fork, i put the modification on the fork i've created https://github.com/vinimoz/polls

@dartcafe
Copy link
Collaborator

I added a PR from your branch #3930

Find comments in the review comments there.

@dartcafe
Copy link
Collaborator

I think i've tried but i wasn't allowed, its look like i need to be a poll developer. So i do a fork, i put the modification on the fork i've created https://github.com/vinimoz/polls

Strange. Until now there were a lot of PRs from foreign branches.

I am confused too. I cannot add myself as a reviewer or assign you to the PR. Maybe you can change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants