Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup CI for pana #1077

Closed
provokateurin opened this issue Nov 2, 2023 · 2 comments
Closed

Setup CI for pana #1077

provokateurin opened this issue Nov 2, 2023 · 2 comments
Assignees
@provokateurin
Labels
feature New feature or request tools Tooling

Comments

@provokateurin
Copy link
Member

A CI for https://github.com/dart-lang/pana should be setup to ensure the quality of our packages is good.

Currently broken because of dart-lang/pana#1212 which is fixed, but only in a version that breaks our dependency constraints...
@provokateurin provokateurin added feature New feature or request tools Tooling labels Nov 2, 2023
@provokateurin provokateurin self-assigned this Nov 2, 2023
@provokateurin provokateurin added the blocked Blocked on other things label Nov 2, 2023
@provokateurin provokateurin added this to the Release 1.0 milestone Nov 2, 2023
@Leptopoda Leptopoda mentioned this issue Jan 12, 2024
Merged
1 task
@provokateurin provokateurin removed this from the Release App 1.0 milestone Jan 16, 2024
@provokateurin provokateurin removed the blocked Blocked on other things label Jan 26, 2024
@provokateurin provokateurin mentioned this issue Jan 26, 2024
Closed
@provokateurin
Copy link
Member Author

Without dart-lang/pana#1020 we can't really use it in CI because the static code analysis will fail once there are breaking changes because it doesn't consider the dependency_overrides.

@Leptopoda
Copy link
Member

Not feasible for every PR.
We should run it before every package is released.

@Leptopoda Leptopoda closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@provokateurin provokateurin

Labels
feature New feature or request tools Tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Leptopoda @provokateurin