feat: Add route to open messages via Message-ID by SoleroTG · Pull Request #12632 · nextcloud/mail

SoleroTG · 2026-03-21T00:08:16Z

Related to #2269

Hi @ChristophWurst, this is the first part of the deep-linking feature.

What this PR does

This PR introduces a new frontend route /apps/mail/open/<message-id> that allows opening a specific email directly if the Message-ID is known.

The app will search for a message with the given ID across all accounts and mailboxes of the user and open it if found.

This is the foundational work for a future UI element that will allow users to copy such a link. The button for generating the link is not part of this PR and will follow in a separate one.

How to test

Find a Message-ID of an existing email (e.g., from the email source).
Manually construct a URL like http://<your-nextcloud-instance>/index.php/apps/mail/open/<your-message-id>.
Make sure to URL-encode the Message-ID (e.g., < becomes %3C).
Navigate to the URL.
The Mail app should open and display the corresponding email directly.

kesselb · 2026-03-30T11:22:05Z

+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors


Suggested change

* SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors

* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors

kesselb · 2026-03-30T11:22:48Z

+		MailAccountMapper $mailAccountMapper,
+		AccountService $accountService,
+		MessageMapper $messageMapper,
+		IURLGenerator $urlGenerator,
+		IUserSession $userSession,
+		LoggerInterface $logger


Suggested change

MailAccountMapper $mailAccountMapper,

AccountService $accountService,

MessageMapper $messageMapper,

IURLGenerator $urlGenerator,

IUserSession $userSession,

LoggerInterface $logger

private MailAccountMapper $mailAccountMapper,

private AccountService $accountService,

private MessageMapper $messageMapper,

private IURLGenerator $urlGenerator,

private IUserSession $userSession,

private LoggerInterface $logger

Adding private/protected/public in a class constructor = shortcut to create a property with the given name and assign the value to it.

kesselb · 2026-03-30T11:22:56Z

+	private MailAccountMapper $mailAccountMapper;
+	private AccountService $accountService;
+	private MessageMapper $messageMapper;
+	private IURLGenerator $urlGenerator;
+	private IUserSession $userSession;
+	private LoggerInterface $logger;


Suggested change

private MailAccountMapper $mailAccountMapper;

private AccountService $accountService;

private MessageMapper $messageMapper;

private IURLGenerator $urlGenerator;

private IUserSession $userSession;

private LoggerInterface $logger;

Still valid. Please use https://stitcher.io/blog/constructor-promotion-in-php-8

kesselb · 2026-03-30T11:23:09Z

+		$this->mailAccountMapper = $mailAccountMapper;
+		$this->accountService = $accountService;
+		$this->messageMapper = $messageMapper;
+		$this->urlGenerator = $urlGenerator;
+		$this->userSession = $userSession;
+		$this->logger = $logger;


Suggested change

$this->mailAccountMapper = $mailAccountMapper;

$this->accountService = $accountService;

$this->messageMapper = $messageMapper;

$this->urlGenerator = $urlGenerator;

$this->userSession = $userSession;

$this->logger = $logger;

kesselb · 2026-03-30T11:24:38Z

+	/**
+	 * @NoAdminRequired
+	 * @NoCSRFRequired
+	 * @PublicPage


Suggested change

* @PublicPage

Not a public page

Still valid

kesselb · 2026-03-30T11:25:24Z

+
+	/**
+	 * @NoAdminRequired
+	 * @NoCSRFRequired


Suggested change

* @NoCSRFRequired

kesselb · 2026-03-30T20:42:20Z

Thanks a lot for your pr, I will give it a test this week.

github-actions · 2026-04-04T02:16:21Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

kesselb · 2026-04-16T12:50:30Z

Thanks again @SoleroTG for your pr.

Please apply the suggested changes.

The linter is failing, could you please format the code accordingly (composer run cs:fix).

Signed-off-by: SoleroTG <github-29h@solero.quietmail.eu>

This adds tests to verify the deep link routing behavior for message-id searches. It uses real instantiations of MailAccount and Message entities instead of mocks to properly test magic methods like getId() and getMailboxId() that cannot be configured on mocks. AI-assisted: Gemini CLI (Gemini 2.5 Pro) Signed-off-by: SoleroTG <github-29h@solero.quietmail.eu>

SoleroTG · 2026-04-18T08:55:56Z

Thanks @kesselb for your feedback.

I have applied the formatting, added the requested unit tests for the DeepLinkController and fixed the DCO issue. The PR is ready for another review!

ChristophWurst · 2026-04-20T07:58:47Z

+	private MailAccountMapper $mailAccountMapper;
+	private AccountService $accountService;
+	private MessageMapper $messageMapper;
+	private IURLGenerator $urlGenerator;
+	private IUserSession $userSession;
+	private LoggerInterface $logger;


Still valid. Please use https://stitcher.io/blog/constructor-promotion-in-php-8

ChristophWurst · 2026-04-20T07:58:56Z

+	/**
+	 * @NoAdminRequired
+	 * @NoCSRFRequired
+	 * @PublicPage


Still valid

ChristophWurst · 2026-04-20T08:00:44Z

+			// Ensure formatting: Always wrapped in <>
+			$cleanedId = '<' . trim($messageId, '<>') . '>';


Use Horde_Mail_Rfc822_Identification like we do at \OCA\Mail\Db\Message::parseMessageId.

Thanks @ChristophWurst for your feedback.

I applied the changes. Please let me know If I forgot anything.

Signed-off-by: SoleroTG <github-29h@solero.quietmail.eu>

SoleroTG requested review from ChristophWurst, GretaD and kesselb as code owners March 21, 2026 00:08

SoleroTG force-pushed the feature/message-id-deeplink branch from 4366c3a to a38f75a Compare March 21, 2026 00:11

SoleroTG mentioned this pull request Mar 21, 2026

Deep links for message IDs #2269

Open

kesselb reviewed Mar 30, 2026

View reviewed changes

kesselb added enhancement 2. developing labels Mar 30, 2026

github-actions Bot added the feedback-requested label Apr 4, 2026

SoleroTG force-pushed the feature/message-id-deeplink branch from a38f75a to 016633b Compare April 16, 2026 23:14

SoleroTG added 4 commits April 18, 2026 10:34

feat(deeplink): implement message-id search and routing

63b1855

Signed-off-by: SoleroTG <github-29h@solero.quietmail.eu>

refactor(deeplink): clean up controller implementation

4bf0c7a

Signed-off-by: SoleroTG <github-29h@solero.quietmail.eu>

style: format code with php-cs-fixer

ba68443

Signed-off-by: SoleroTG <github-29h@solero.quietmail.eu>

SoleroTG force-pushed the feature/message-id-deeplink branch from d3e675a to 4ce7b44 Compare April 18, 2026 08:38

ChristophWurst requested changes Apr 20, 2026

View reviewed changes

fix(deeplink): apply PR review feedback

02a4799

Signed-off-by: SoleroTG <github-29h@solero.quietmail.eu>

	* SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
	* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors

		// Ensure formatting: Always wrapped in <>
		$cleanedId = '<' . trim($messageId, '<>') . '>';

Conversation

SoleroTG commented Mar 21, 2026

What this PR does

How to test

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kesselb commented Mar 30, 2026

Uh oh!

github-actions Bot commented Apr 4, 2026

Uh oh!

kesselb commented Apr 16, 2026

Uh oh!

SoleroTG commented Apr 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants