Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show and resize user avatars in Zulip search results #34

Open
edward-ly opened this issue Dec 2, 2024 · 0 comments
Open

Show and resize user avatars in Zulip search results #34

edward-ly opened this issue Dec 2, 2024 · 0 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement New feature or request

Comments

@edward-ly
Copy link
Collaborator

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature request

Which Nextcloud Version are you currently using: master

Describe the solution you'd like
As a follow-up to #33, it would be nice if the default icons could be replaced with the avatar of Zulip user whose message is displayed in the search result.

Is your feature request related to a problem? Please describe.
Currently, such images are not resized correctly for each search result entry.

Describe alternatives you've considered
N/A

Additional context
See the commented out lines in lib/Search/ZulipSearchMessagesProvider.php::getThumbnailUrl which enable user avatars (albeit with incorrect sizes).

@edward-ly edward-ly added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement New feature or request labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant