Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error 500 after updating to latest groupfolders version #3120

Closed
HerrBeef opened this issue Aug 16, 2024 · 20 comments
Closed

Error 500 after updating to latest groupfolders version #3120

HerrBeef opened this issue Aug 16, 2024 · 20 comments
Assignees
Labels
0. Needs triage Issues that need to be triaged bug

Comments

@HerrBeef
Copy link

HerrBeef commented Aug 16, 2024

Steps to reproduce

  1. Update Groupfolders from 17.0.1 to 17.0.2
  2. Nextcloud very broken at least for me...
    visting any page results in error 500

Expected behaviour

Nextcloud should work.

Actual behaviour

Visting any page will result in Error 500.

Server configuration

Nextcloud AIO v9.4.1

Nextcloud version: (see Nextcloud admin page)
29.0.4
Group folders version:
17.0.2
Updated from an older Nextcloud/ownCloud or fresh install:
Updated from previous Nextcloud AIO Versions
Where did you install Nextcloud from:
Official Docker
Are you using external storage, if yes which one: local/s3/smb/sftp/...
No
Are you using encryption: yes/no
No
Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/Saml/...
No

Client configuration

Browser:
Any browser

Logs

`Error no app in context Exception: Too few arguments to function 2024-08-16T18:53:27+00:00
OCA\GroupFolders\Folder\FolderManager::__construct(), 4 passed in
/var/www/html/custom_apps/files_fulltextsearch/lib/Service/GroupFoldersService.php on
line 67 and exactly 5 expected in file
'/var/www/html/custom_apps/groupfolders/lib/Folder/FolderManager.php' line 52 at
lib/private/AppFramework/Http/Dispatcher.php line 170

                          0. .../private/AppFramework/App.php line 184                                                                       
                             OC\AppFramework\Http\Dispatcher->dispatch(                                                                      
                               ["OC\\Core\\Controller\\OCSController"],                                                                      
                               "getCapabilities"                                                                                             
                             )                                                                                                               
                          1. lib/private/Route/Router.php line 338                                                                           
                             OC\AppFramework\App::main(                                                                                      
                               "OC\\Core\\Controller\\OCSController",                                                                        
                               "getCapabilities",                                                                                            
                               ["OC\\AppFramework\\DependencyInjection\\DIContainer"],                                                       
                               ["ocs.core.ocs.getcapabilities"]                                                                              
                             )                                                                                                               
                          2. ocs/v1.php line 66                                                                                              
                             OC\Route\Router->match("\/ocsapp\/cloud\/capabilities")                                                         
                          3. ocs/v2.php line 23                                                                                              
                             require_once("\/var\/www\/html\/ocs\/v1.php")                                                                   
                                                                                                                                             
                          Caused by ArgumentCountError: Too few arguments to function                                                        
                          OCA\GroupFolders\Folder\FolderManager::__construct(), 4 passed in                                                  
                          /var/www/html/custom_apps/files_fulltextsearch/lib/Service/GroupFoldersService.php on                              
                          line 67 and exactly 5 expected at .../groupfolders/lib/Folder/FolderManager.php line 52                            
                                                                                                                                             
                           0. .../GroupFoldersService.php line 67                                                                            
                              OCA\GroupFolders\Folder\FolderManager->__construct(                                                            
                                ["OC\\DB\\ConnectionAdapter"],                                                                               
                                ["OC\\Group\\Manager"],                                                                                      
                                ["OC\\Files\\Type\\Loader"],                                                                                 
                                ["OC\\AppFramework\\Sco ... "]                                                                               
                              )                                                                                                              
                           1. <<closure>>                                                                                                    
                              OCA\Files_FullTextSearch\Service\GroupFoldersService->__construct(                                             
                                ["OC\\DB ... "],                                                                                             
                                ["OC\\Ap ... "],                                                                                             
                                ["OC\\Fi ... "],                                                                                             
                                ["OC\\Gr ... "],                                                                                             
                                ["OCA\\F ... "],                                                                                             
                                ["OCA\\F ... ]],                                                                                             
                                ["OC\\Ap ... "]                                                                                              
                              )                                                                                                              
                           2. .../Utility/SimpleContainer.php line 83                                                                        
                              ReflectionClass->newInstanceArgs([["OC\\DB\\ConnectionAdapter"],["OC\\App\ ... "])                             
                           3. .../SimpleContainer.php line 128                                                                               
                              OC\AppFramework\Utility\SimpleContainer->buildClass(["ReflectionClass","OC ... "])                             
                           4. .../SimpleContainer.php line 146                                                                               
                              OC\AppFramework\Utility\SimpleContainer->resolve("OCA\\Files_FullTextSearc ... e")                             
                           5. .../DIContainer.php line 471                                                                                   
                              OC\AppFramework\Utility\SimpleContainer->query("OCA\\Files_FullTextSearch\ ... e")                             
                           6. .../DIContainer.php line 443                                                                                   
                              OC\AppFramework\DependencyInjection\DIContainer->queryNoFallback("OCA\\Fil ... e")                             
                           7. .../SimpleContainer.php line 96                                                                                
                              OC\AppFramework\DependencyInjection\DIContainer->query(                                                        
                                "OCA\\Files_FullTex ... e",                                                                                  
                                true                                                                                                         
                              )                                                                                                              
                           8. <<closure>>                                                                                                    
                              OC\AppFramework\Utility\SimpleContainer->OC\AppFramework\Utility\{closure}(                                    
                                "*** sensitive parameters replaced *** ... *"                                                                
                              )                                                                                                              
                           9. lib/private/AppFramework/Utility/SimpleContainer.php line 83                                                   
                              array_map(                                                                                                     
                                ["Closure"],                                                                                                 
                                [["ReflectionParameter","container"],["ReflectionParameter","roo ... "]                                      
                              )                                                                                                              
                          10. .../SimpleContainer.php line 128                                                                               
                              OC\AppFramework\Utility\SimpleContainer->buildClass(["ReflectionClass","OC ... "])                             
                          11. .../SimpleContainer.php line 146                                                                               
                              OC\AppFramework\Utility\SimpleContainer->resolve("OCA\\Files_FullTextSearc ... e")                             
                          12. .../DIContainer.php line 471                                                                                   
                              OC\AppFramework\Utility\SimpleContainer->query("OCA\\Files_FullTextSearch\ ... e")                             
                          13. .../DIContainer.php line 443                                                                                   
                              OC\AppFramework\DependencyInjection\DIContainer->queryNoFallback("OCA\\Fil ... e")                             
                          14. .../SimpleContainer.php line 96                                                                                
                              OC\AppFramework\DependencyInjection\DIContainer->query(                                                        
                                "OCA\\Files_FullTex ... e",                                                                                  
                                true                                                                                                         
                              )                                                                                                              
                          15. <<closure>>                                                                                                    
                              OC\AppFramework\Utility\SimpleContainer->OC\AppFramework\Utility\{closure}(                                    
                                "*** sensitive parameters replaced *** ... *"                                                                
                              )                                                                                                              
                          16. lib/private/AppFramework/Utility/SimpleContainer.php line 83                                                   
                              array_map(                                                                                                     
                                ["Closure"],                                                                                                 
                                [["ReflectionParameter","l10n"],["ReflectionParameter","configSe ... "]                                      
                              )                                                                                                              
                          17. .../SimpleContainer.php line 128                                                                               
                              OC\AppFramework\Utility\SimpleContainer->buildClass(["ReflectionClass","OC ... "])                             
                          18. .../SimpleContainer.php line 146                                                                               
                              OC\AppFramework\Utility\SimpleContainer->resolve("OCA\\Files_FullTextSearc ... r")                             
                          19. .../DIContainer.php line 471                                                                                   
                              OC\AppFramework\Utility\SimpleContainer->query("OCA\\Files_FullTextSearch\ ... r")                             
                          20. .../ServerContainer.php line 155                                                                               
                              OC\AppFramework\DependencyInjection\DIContainer->queryNoFallback("OCA\\Fil ... r")                             
                          21. .../lib/Service/ProviderService.php line 121                                                                   
                              OC\ServerContainer->query("OCA\\Files_FullTextSearch\\Provider\\FilesProvider")                                
                          22. .../ProviderService.php line 267                                                                               
                              OCA\FullTextSearch\Service\ProviderService->loadProvider(                                                      
                                "files_fulltextsearch",                                                                                      
                                "OCA\\Files_FullT ... r"                                                                                     
                              )                                                                                                              
                          23. .../ProviderService.php line 238                                                                               
                              OCA\FullTextSearch\Service\ProviderService->loadProvidersFromList(                                             
                                "files_f ... h",                                                                                             
                                ["OCA\\F ... "]                                                                                              
                              )                                                                                                              
                          24. .../ProviderService.php line 101                                                                               
                              OCA\FullTextSearch\Service\ProviderService->loadProvidersFromApp("files_fu ... h")                             
                          25. .../ProviderService.php line 155                                                                               
                              OCA\FullTextSearch\Service\ProviderService->loadProviders(                                                     
                                                                                                                                             
                              )                                                                                                              
                          26. .../Capabilities.php line 80                                                                                   
                              OCA\FullTextSearch\Service\ProviderService->getConfiguredProviders(                                            
                                                                                                                                             
                              )                                                                                                              
                          27. .../CapabilitiesManager.php line 74                                                                            
                              OCA\FullTextSearch\Capabilities->getCapabilities(                                                              
                                                                                                                                             
                              )                                                                                                              
                          28. .../Controller/OCSController.php line 93                                                                       
                              OC\CapabilitiesManager->getCapabilities(                                                                       
                                                                                                                                             
                              )                                                                                                              
                          29. .../Http/Dispatcher.php line 232                                                                               
                              OC\Core\Controller\OCSController->getCapabilities(                                                             
                                                                                                                                             
                              )                                                                                                              
                          30. .../Dispatcher.php line 138                                                                                    
                              OC\AppFramework\Http\Dispatcher->executeController(                                                            
                                ["OC\\Core\\Controller\ ... "],                                                                              
                                "getCapabilities"                                                                                            
                              )                                                                                                              
                          31. .../AppFramework/App.php line 184                                                                              
                              OC\AppFramework\Http\Dispatcher->dispatch(                                                                     
                                ["OC\\Core\\Controller\\OCSController"],                                                                     
                                "getCapabilities"                                                                                            
                              )                                                                                                              
                          32. lib/private/Route/Router.php line 338                                                                          
                              OC\AppFramework\App::main(                                                                                     
                                "OC\\Core\\Controller\\OCSController",                                                                       
                                "getCapabilities",                                                                                           
                                ["OC\\AppFramework\\DependencyInjection\\DIContainer"],                                                      
                                ["ocs.core.ocs.getcapabilities"]                                                                             
                              )                                                                                                              
                          33. ocs/v1.php line 66                                                                                             
                              OC\Route\Router->match("\/ocsapp\/cloud\/capabilities")                                                        
                          34. ocs/v2.php line 23                                                                                             
                              require_once("\/var\/www\/html\/ocs\/v1.php")                                                                  

`

@HerrBeef HerrBeef added 0. Needs triage Issues that need to be triaged bug labels Aug 16, 2024
@dirkpape
Copy link

Also happening when upgrading from 17.0.1 to 17.02 on NC 29.0.4

@HerrBeef
Copy link
Author

yes, was also 17.0.1 to 17.0.2 tought it was 18.0.0 but that was a mistake, now i saw it was indeed 17.0.1 to 17.0.2. i updated my description

@Pavuucek
Copy link

It's already discussed at nextcloud/files_fulltextsearch#265 including a fix.

@ostasevych
Copy link

Hi! What about updating from 16.0.7 to 16.0.8 at NC28.0.8? Is it also broken similarly?

@xTGHHx
Copy link

xTGHHx commented Aug 17, 2024

Same here. NC 29.0.4

@jurgenhaas
Copy link

jurgenhaas commented Aug 17, 2024

Me too. Groupfolders 17.0.2 on NC 29.0.4

Too few arguments to function OCA\\GroupFolders\\Folder\\FolderManager::__construct(), 4 passed in /var/www/html/apps/files_fulltextsearch/lib/Service/GroupFoldersService.php on line 68 and exactly 5 expected

@artem-bm
Copy link

NC 29.0.4, GroupFolders 17.0.2 - NC not working ... downgrade to GF 17.0.0

@snoweuph
Copy link

snoweuph commented Aug 17, 2024

Same, for now I just disabled it with occ,because there doesnt seem to be a downgrade command

This is a Request, wher im not logged in trying to access the login page, when its enabled:

d05e9b3643c4:/var/www/html$ php occ log:watch
  Error    index              ArgumentCountError: Too few arguments to function OCA\GroupFolders\Folder\FolderManager::__construct(), 4 passed in                                                                2024-08-17T19:31:30+00:00 
                              /var/www/html/custom_apps/files_fulltextsearch/lib/Service/GroupFoldersService.php on line 67 and exactly 5 expected at .../groupfolders/lib/Folder/FolderManager.php line 52                                
                                                                                                                                                                                                                                           
                               0. custom_apps/files_fulltextsearch/lib/Service/GroupFoldersService.php line 67                                                                                                                             
                                  OCA\GroupFolders\Folder\FolderManager->__construct(                                                                                                                                                      
                                    ["OC\\DB\\ConnectionAdapter"],                                                                                                                                                                         
                                    ["OC\\Group\\Manager"],                                                                                                                                                                                
                                    ["OC\\Files\\Type\\Loader"],                                                                                                                                                                           
                                    ["OC\\AppFramework\\ScopedPsrLogger"]                                                                                                                                                                  
                                  )                                                                                                                                                                                                        
                               1. <<closure>>                                                                                                                                                                                              
                                  OCA\Files_FullTextSearch\Service\GroupFoldersService->__construct(                                                                                                                                       
                                    ["OC\\DB\\ConnectionAdapter"],                                                                                                                                                                         
                                    ["OC\\App\\AppManager"],                                                                                                                                                                               
                                    ["OC\\Files\\Type\\Loader"],                                                                                                                                                                           
                                    ["OC\\Group\\Manager"],                                                                                                                                                                                
                                    ["OCA\\Files_FullTextSearch\\Service\\LocalFilesService"],                                                                                                                                             
                                    ["OCA\\Files_FullTextSearch\\Service\\ConfigService",["1","0","0","0","0","And 6 more entries, set ... ]],                                                                                             
                                    ["OC\\AppFramework\\ScopedPsrLogger"]                                                                                                                                                                  
                                  )                                                                                                                                                                                                        
                               2. lib/private/AppFramework/Utility/SimpleContainer.php line 83                                                                                                                                             
                                  ReflectionClass->newInstanceArgs([["OC\\DB\\ConnectionAdapter"],["OC\\App\\AppManager"],["OC\\Files\\Type\\Loader"],["OC\\Group\\Manager"],["OCA\\Files_FullTextSear ... "])                             
                               3. lib/private/AppFramework/Utility/SimpleContainer.php line 128                                                                                                                                            
                                  OC\AppFramework\Utility\SimpleContainer->buildClass(["ReflectionClass","OCA\\Files_FullTextSearch\\Service\\GroupFoldersService"])                                                                       
                               4. lib/private/AppFramework/Utility/SimpleContainer.php line 146                                                                                                                                            
                                  OC\AppFramework\Utility\SimpleContainer->resolve("OCA\\Files_FullTextSearch\\Service\\GroupFoldersService")                                                                                              
                               5. lib/private/AppFramework/DependencyInjection/DIContainer.php line 471                                                                                                                                    
                                  OC\AppFramework\Utility\SimpleContainer->query("OCA\\Files_FullTextSearch\\Service\\GroupFoldersService")                                                                                                
                               6. lib/private/AppFramework/DependencyInjection/DIContainer.php line 443                                                                                                                                    
                                  OC\AppFramework\DependencyInjection\DIContainer->queryNoFallback("OCA\\Files_FullTextSearch\\Service\\GroupFoldersService")                                                                              
                               7. lib/private/AppFramework/Utility/SimpleContainer.php line 96                                                                                                                                             
                                  OC\AppFramework\DependencyInjection\DIContainer->query("OCA\\Files_FullTextSearch\\Service\\GroupFoldersService", true)                                                                                  
                               8. <<closure>>                                                                                                                                                                                              
                                  OC\AppFramework\Utility\SimpleContainer->OC\AppFramework\Utility\{closure}("*** sensitive parameters replaced ***")                                                                                      
                               9. lib/private/AppFramework/Utility/SimpleContainer.php line 83                                                                                                                                             
                                  array_map(                                                                                                                                                                                               
                                    ["Closure"],                                                                                                                                                                                           
                                    [["ReflectionParameter","container"],["ReflectionParameter","rootFolder"],["ReflectionParameter","appManager"],["ReflectionParameter","userManager"],["Ref ... "]                                      
                                  )                                                                                                                                                                                                        
                              10. lib/private/AppFramework/Utility/SimpleContainer.php line 128                                                                                                                                            
                                  OC\AppFramework\Utility\SimpleContainer->buildClass(["ReflectionClass","OCA\\Files_FullTextSearch\\Service\\FilesService"])                                                                              
                              11. lib/private/AppFramework/Utility/SimpleContainer.php line 146                                                                                                                                            
                                  OC\AppFramework\Utility\SimpleContainer->resolve("OCA\\Files_FullTextSearch\\Service\\FilesService")                                                                                                     
                              12. lib/private/AppFramework/DependencyInjection/DIContainer.php line 471                                                                                                                                    
                                  OC\AppFramework\Utility\SimpleContainer->query("OCA\\Files_FullTextSearch\\Service\\FilesService")                                                                                                       
                              13. lib/private/AppFramework/DependencyInjection/DIContainer.php line 443                                                                                                                                    
                                  OC\AppFramework\DependencyInjection\DIContainer->queryNoFallback("OCA\\Files_FullTextSearch\\Service\\FilesService")                                                                                     
                              14. lib/private/AppFramework/Utility/SimpleContainer.php line 96                                                                                                                                             
                                  OC\AppFramework\DependencyInjection\DIContainer->query("OCA\\Files_FullTextSearch\\Service\\FilesService", true)                                                                                         
                              15. <<closure>>                                                                                                                                                                                              
                                  OC\AppFramework\Utility\SimpleContainer->OC\AppFramework\Utility\{closure}("*** sensitive parameters replaced ***")                                                                                      
                              16. lib/private/AppFramework/Utility/SimpleContainer.php line 83                                                                                                                                             
                                  array_map(                                                                                                                                                                                               
                                    ["Closure"],                                                                                                                                                                                           
                                    [["ReflectionParameter","l10n"],["ReflectionParameter","configService"],"*** sensitive parameters replaced ***",["ReflectionParameter","searchService"],[" ... "]                                      
                                  )                                                                                                                                                                                                        
                              17. lib/private/AppFramework/Utility/SimpleContainer.php line 128                                                                                                                                            
                                  OC\AppFramework\Utility\SimpleContainer->buildClass(["ReflectionClass","OCA\\Files_FullTextSearch\\Provider\\FilesProvider"])                                                                            
                              18. lib/private/AppFramework/Utility/SimpleContainer.php line 146                                                                                                                                            
                                  OC\AppFramework\Utility\SimpleContainer->resolve("OCA\\Files_FullTextSearch\\Provider\\FilesProvider")                                                                                                   
                              19. lib/private/AppFramework/DependencyInjection/DIContainer.php line 471                                                                                                                                    
                                  OC\AppFramework\Utility\SimpleContainer->query("OCA\\Files_FullTextSearch\\Provider\\FilesProvider")                                                                                                     
                              20. lib/private/ServerContainer.php line 155                                                                                                                                                                 
                                  OC\AppFramework\DependencyInjection\DIContainer->queryNoFallback("OCA\\Files_FullTextSearch\\Provider\\FilesProvider")                                                                                   
                              21. custom_apps/fulltextsearch/lib/Service/ProviderService.php line 121                                                                                                                                      
                                  OC\ServerContainer->query("OCA\\Files_FullTextSearch\\Provider\\FilesProvider")                                                                                                                          
                              22. custom_apps/fulltextsearch/lib/Service/ProviderService.php line 267                                                                                                                                      
                                  OCA\FullTextSearch\Service\ProviderService->loadProvider("files_fulltextsearch", "OCA\\Files_FullTextSearch\\Provider\\FilesProvider")                                                                   
                              23. custom_apps/fulltextsearch/lib/Service/ProviderService.php line 238                                                                                                                                      
                                  OCA\FullTextSearch\Service\ProviderService->loadProvidersFromList("files_fulltextsearch", ["OCA\\Files_FullTextSearch\\Provider\\FilesProvider"])                                                        
                              24. custom_apps/fulltextsearch/lib/Service/ProviderService.php line 101                                                                                                                                      
                                  OCA\FullTextSearch\Service\ProviderService->loadProvidersFromApp("files_fulltextsearch")                                                                                                                 
                              25. custom_apps/fulltextsearch/lib/Service/ProviderService.php line 155                                                                                                                                      
                                  OCA\FullTextSearch\Service\ProviderService->loadProviders(                                                                                                                                               
                                                                                                                                                                                                                                           
                                  )                                                                                                                                                                                                        
                              26. custom_apps/fulltextsearch/lib/Capabilities.php line 80                                                                                                                                                  
                                  OCA\FullTextSearch\Service\ProviderService->getConfiguredProviders(                                                                                                                                      
                                                                                                                                                                                                                                           
                                  )                                                                                                                                                                                                        
                              27. lib/private/CapabilitiesManager.php line 74                                                                                                                                                              
                                  OCA\FullTextSearch\Capabilities->getCapabilities(                                                                                                                                                        
                                                                                                                                                                                                                                           
                                  )                                                                                                                                                                                                        
                              28. lib/private/Template/JSConfigHelper.php line 157                                                                                                                                                         
                                  OC\CapabilitiesManager->getCapabilities(false, true)                                                                                                                                                     
                              29. lib/private/TemplateLayout.php line 266                                                                                                                                                                  
                                  OC\Template\JSConfigHelper->getConfig(                                                                                                                                                                   
                                                                                                                                                                                                                                           
                                  )                                                                                                                                                                                                        
                              30. lib/private/legacy/OC_Template.php line 145                                                                                                                                                              
                                  OC\TemplateLayout->__construct("guest", "core")                                                                                                                                                          
                              31. lib/public/AppFramework/Http/TemplateResponse.php line 211                                                                                                                                               
                                  OC_Template->fetchPage([[],"Login"])                                                                                                                                                                     
                              32. lib/private/AppFramework/Http/Dispatcher.php line 183                                                                                                                                                    
                                  OCP\AppFramework\Http\TemplateResponse->render(                                                                                                                                                          
                                                                                                                                                                                                                                           
                                  )                                                                                                                                                                                                        
                              33. lib/private/AppFramework/App.php line 184                                                                                                                                                                
                                  OC\AppFramework\Http\Dispatcher->dispatch(["OC\\Core\\Controller\\LoginController"], "showLoginForm")                                                                                                    
                              34. lib/private/Route/Router.php line 338                                                                                                                                                                    
                                  OC\AppFramework\App::main("OC\\Core\\Controller\\LoginController", "showLoginForm", ["OC\\AppFramework\\DependencyInjection\\DIContainer"], ["core.login.showloginform"])                                
                              35. lib/base.php line 1050                                                                                                                                                                                   
                                  OC\Route\Router->match("\/login")                                                                                                                                                                        
                              36. index.php line 49                                                                                                                                                                                        
                                  OC::handleRequest(                                                                                                                                                                                       
                                                                                                                                                                                                                                           
                                  )

@cibomato
Copy link

Same problem here: updated groupfolders from 17.0.1 to 17.0.2 via Webupdater on NC 29.0.4.
Afterwards NC isn't accessible any longer!
Aftre disabling via occ app:disable groupfolders NC works again, but I need groupfolders! So I tried to activate and update it via occ but NC vanishes again....

What to do?
Is there a possibility to downgrade groupfolders to 17.0.1?
Or any other solution?

Thanks in advance! Best regards,
Jochen

@sebix
Copy link

sebix commented Aug 18, 2024

What to do? Is there a possibility to downgrade groupfolders to 17.0.1? Or any other solution?

Just apply the patch from nextcloud/files_fulltextsearch#265 as mentioned above.

@snoweuph
Copy link

What to do? Is there a possibility to downgrade groupfolders to 17.0.1? Or any other solution?

Just apply the patch from nextcloud/files_fulltextsearch#265 as mentioned above.

so this plugins isnt the source of problem, but the search?

@artem-bm
Copy link

artem-bm commented Aug 18, 2024 via email

@sebix
Copy link

sebix commented Aug 18, 2024

so this plugins isnt the source of problem, but the search?

Well, both.
The Fulltextsearch app has some code to provide the search also for groupfolders and queries that app for some information.
Then, the group folders app changed its API, and the full-text search crashed as it expected the previous API. So it needs an update to stay compatible with the current group folders app. In the aftermath, we can now say that it would have been better if both app developers had coordinated to run more tests to check their compatibility before releasing, but stating that afterward is always easy.

@cibomato
Copy link

I applied the patch as described above and it works now with groupfolders 17.0.2. Hope that it isn't just a workaround but consistent after future updates.
Thank you!

@sebix
Copy link

sebix commented Aug 18, 2024

Hope that it isn't just a workaround but consistent after future updates.

If the full-text search app developers incorporate the patch (or any equivalent fix) into the next version, there won't be a problem again.

Otherwise, if the next version of the full-text search app does not include the fix, as soon as we get the update, the error will re-appear, as the patched files will get overridden.
I think we can safely assume that the developers are aware of the issue and will use the patch :)

@alphasixtyfive
Copy link

Hope that it isn't just a workaround but consistent after future updates.

If the full-text search app developers incorporate the patch (or any equivalent fix) into the next version, there won't be a problem again.

Otherwise, if the next version of the full-text search app does not include the fix, as soon as we get the update, the error will re-appear, as the patched files will get overridden. I think we can safely assume that the developers are aware of the issue and will use the patch :)

The fact that last release of fulltextsearch was in 2022 and there is still no PR to address the is rather worrying.

@AndyScherzinger
Copy link
Member

I think we can safely assume that the developers are aware of the issue and will use the patch :)

Yes 👍

The fact that last release of fulltextsearch was in 2022 and there is still no PR to address the is rather worrying.

This is currently being looked into by @sorbaugh and @ArtificialOwl 👍

@jurgenhaas
Copy link

Looks like fulltextsearch and fulltextsearch_files provided new released 29.0.1 and they work together with groupfolders 17.0.2 - the issue is thereby resolved, I guess.

@loxK
Copy link

loxK commented Aug 22, 2024

Working :

fulltextsearch_files v28.0.1
Nextcloud v28.0.9
Group folders v16.0.8

Thanks

@sorbaugh
Copy link
Contributor

Seems it was fixed with nextcloud/files_fulltextsearch#266

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Issues that need to be triaged bug
Projects
None yet
Development

No branches or pull requests