Add Option to Open Files Directly from Search Results #253
Conversation
And0r-
force-pushed
the
add_open_results_directly
branch
from
855d267
to
0e81576
Compare
|
I wanted to provide a quick update on this PR. I've noticed that the implemented method for directly opening files from search results may not be functioning as expected in Nextcloud version 28. I am currently investigating this issue to better understand why this is happening and to find a suitable solution. I will update this PR with any new findings or necessary code adjustments as soon as possible. Meanwhile, I appreciate your patience and welcome any feedback or suggestions from the community. |
…rectory Signed-off-by: DESKTOP-E98Q6N0\And0r <[email protected]>
Signed-off-by: DESKTOP-E98Q6N0\And0r <[email protected]>
…m nextcloud do it (FileSearchProvider.php#154) this will create a link like /f/<file_id> that works in previews and version nc 28. it is a little bit ugly because you will be redirected multiple time but better as a broken Link Signed-off-by: DESKTOP-E98Q6N0\And0r <[email protected]>
And0r-
force-pushed
the
add_open_results_directly
branch
from
da7a0f5
to
9ea3738
Compare
|
I'm pleased to provide an update on this Pull Request. After further investigation, I discovered that the initial method for opening files directly from search results needed an adjustment for compatibility with Nextcloud version 28. I have now updated the implementation to align with the method used in Nextcloud's official $link = $this->urlGenerator->linkToRoute('files.View.showFile', ['fileid' => $document->getId()]);This change should resolve the issues observed with Nextcloud 28, and the feature now functions as intended across different Nextcloud versions. I have tested this thoroughly to ensure its reliability and compatibility. I believe this update will enhance the user experience by providing a more efficient way to access files directly from search results. Your review and feedback on these changes would be greatly appreciated. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
|
Hi @ArtificialOwl, Alternatively, if the feature won't be merged because there's not enough interest, it would be helpful to know. In that case, I'll create a userscript workaround for myself to remain update-capable. |
|
@ArtificialOwl is this pull request still on your radar? If you don't have time for it, could you please raise it to Stephan? |
|
/backport to stable28 |
|
/backport to stable27 |
The ability to open a file directly from search results, as requested in Issue #249, is a very useful feature. This idea was initially proposed by ostasevych in Pull Request #250.
I've implemented this feature and added an option to the plugin settings. By default, the current behavior remains unchanged. However, users now have the choice to enable direct opening of files from search results. This enhancement aims to improve user experience by providing a more efficient way to access files through search.
Please review the changes and consider merging them into the main project. Thank you for your consideration!