`occ fulltextsearch:index` throws NULL Pointer on `isGlobal` #125

bronnertm · 2021-05-17T21:30:12Z

Hi,

When I issue the fulltextsearch:index command I only get a NULL Pointer execption.

An unhandled exception has been thrown: TypeError: Return value of OCA\Files_FullTextSearch\Model\MountPoint::isGlobal() must be of the type bool, null returned in /var/www/html/custom_apps/files_fulltextsearch/lib/Model/MountPoint.php:103 Stack trace: #0 /var/www/html/custom_apps/files_fulltextsearch/lib/Model/MountPoint.php(175): OCA\Files_FullTextSearch\Model\MountPoint->isGlobal() #1 [internal function]: OCA\Files_FullTextSearch\Model\MountPoint->jsonSerialize() #2 /var/www/html/custom_apps/files_fulltextsearch/lib/TNC22Logger.php(193): json_encode(Array) #3 /var/www/html/custom_apps/files_fulltextsearch/lib/TNC22Logger.php(178): OCA\Files_FullTextSearch\Service\GroupFoldersService->log(0, '[debug] initGro...', false, Array) #4 /var/www/html/custom_apps/files_fulltextsearch/lib/Service/GroupFoldersService.php(133): OCA\Files_FullTextSearch\Service\GroupFoldersService->debug('[debug] initGro...', Array) #5 /var/www/html/custom_apps/files_fulltextsearch/lib/Service/FilesService.php(379): OCA\Files_FullTextSearch\Service\GroupFoldersService->initGroupSharesForUser('birte') #6 /var/www/html/custom_apps/files_fulltextsearch/lib/Service/FilesService.php(202): OCA\Files_FullTextSearch\Service\FilesService->initFileSystems('birte') #7 /var/www/html/custom_apps/files_fulltextsearch/lib/Provider/FilesProvider.php(249): OCA\Files_FullTextSearch\Service\FilesService->getChunksFromUser('birte', Object(OCA\FullTextSearch\Model\IndexOptions)) #8 /var/www/html/custom_apps/fulltextsearch/lib/Service/IndexService.php(182): OCA\Files_FullTextSearch\Provider\FilesProvider->generateChunks('birte') #9 /var/www/html/custom_apps/fulltextsearch/lib/Command/Index.php(410): OCA\FullTextSearch\Service\IndexService->indexProviderContentFromUser(Object(OCA\FullTextSearch_Elasticsearch\Platform\ElasticSearchPlatform), Object(OCA\Files_FullTextSearch\Provider\FilesProvider), 'birte', Object(OCA\FullTextSearch\Model\IndexOptions)) #10 /var/www/html/custom_apps/fulltextsearch/lib/Command/Index.php(273): OCA\FullTextSearch\Command\Index->indexProvider(Object(OCA\Files_FullTextSearch\Provider\FilesProvider), Object(OCA\FullTextSearch\Model\IndexOptions)) #11 /var/www/html/3rdparty/symfony/console/Command/Command.php(255): OCA\FullTextSearch\Command\Index->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #12 /var/www/html/core/Command/Base.php(169): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #13 /var/www/html/3rdparty/symfony/console/Application.php(1009): OC\Core\Command\Base->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #14 /var/www/html/3rdparty/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand(Object(OCA\FullTextSearch\Command\Index), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #15 /var/www/html/3rdparty/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #16 /var/www/html/lib/private/Console/Application.php(215): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) #17 /var/www/html/console.php(100): OC\Console\Application->run() #18 /var/www/html/occ(11): require_once('/var/www/html/c...')

My NC version is 21.0.1
Fulltextsearch + the Eleastic Platform is on 21.0.1 and Files is on 21.0.2
Group Folders is on 9.01
My PHP version is: 7.4.19

When I disable the group folders addon in NC the index job will start without an issue. Can someone please point me in the right direction or is this a known issue, because NC 21 is not supported right now?

Thanks Matthias

The text was updated successfully, but these errors were encountered:

tarradmac · 2021-05-18T13:33:51Z

Hi I have the same error on NC 20.0.9 + FTS 20.0.1 + Files 20.0.3.
Try to reset all index, rescan all files but search is not working.
the test command work perfectly...
I am using group folders 8.2.1

I tried on a fresh install with the same version as I use in production, and got the same behavior. Like @bronnertm I had to disable Group Folders app to get indexing working. Disabling in fulltextsearch setting is not working.

jurgenhaas · 2021-05-19T07:19:13Z

Same here with NC 21.0.1 + FTS 21.0.1 + FTS Files 21.0.2
Even when I disable group folders in the settings, it's still throwing that exception.

ShinjiLE · 2021-05-19T14:27:02Z

Same here .
My first quick fix is to comment out the point where the debug call to the logger appears .
In : apps/files_fulltextsearch/lib/Service/GroupFoldersService.php , Line 133

g-d-d-h · 2021-06-02T04:43:36Z

I have the same problem.

thomasgg23 · 2021-06-04T08:25:19Z

Same here .
My first quick fix is to comment out the point where the debug call to the logger appears .
In : apps/files_fulltextsearch/lib/Service/GroupFoldersService.php , Line 133

Thanks @ShinjiLE the quickfix seems to be working.
Will get to it when indexing is done

redRolf · 2021-06-15T20:46:14Z

I am experiencing the same issue at our company. Unfortunately commenting out lines, is not an option, as were are using a Docker deployment, which means changes would be non-persistent. Is anybody working on this?
I am happy to supply logs, version numbers, etc.. if needed. Here are the basics:

Nextcloud: 21.0.2
PHP Version: 7.4.20
Group Folders: 9.0.1
Full text search - Files: 21.0.2
Full text search - Elasticsearch Platform: 21.0.1

Omaha2002 · 2021-06-20T09:41:32Z

Comment out the point suggested by @ShinjiLE helps getting the indexing started but after indexing a lot of files and users with groupfolders enabled I get the following error:

An unhandled exception has been thrown:
Error: Call to a member function getOwner() on null in /var/www/nextcloud/lib/private/Share20/Manager.php:1651
Stack trace:
#0 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/LocalFilesService.php(163): OC\Share20\Manager->getAccessList()
#1 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(795): OCA\Files_FullTextSearch\Service\LocalFilesService->getShareUsersFromFile()
#2 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(725): OCA\Files_FullTextSearch\Service\FilesService->updateShareNames()
#3 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(699): OCA\Files_FullTextSearch\Service\FilesService->updateDocumentAccess()
#4 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(680): OCA\Files_FullTextSearch\Service\FilesService->updateFilesDocumentFromFile()
#5 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(571): OCA\Files_FullTextSearch\Service\FilesService->updateFilesDocument()
#6 /var/www/nextcloud/apps/files_fulltextsearch/lib/Provider/FilesProvider.php(288): OCA\Files_FullTextSearch\Service\FilesService->generateDocument()
#7 /var/www/nextcloud/apps/fulltextsearch/lib/Service/IndexService.php(317): OCA\Files_FullTextSearch\Provider\FilesProvider->fillIndexDocument()
#8 /var/www/nextcloud/apps/fulltextsearch/lib/Service/IndexService.php(204): OCA\FullTextSearch\Service\IndexService->indexDocuments()
#9 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(410): OCA\FullTextSearch\Service\IndexService->indexProviderContentFromUser()
#10 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(273): OCA\FullTextSearch\Command\Index->indexProvider()
#11 /var/www/nextcloud/apps/bookmarks/vendor/symfony/console/Command/Command.php(255): OCA\FullTextSearch\Command\Index->execute()
#12 /var/www/nextcloud/core/Command/Base.php(169): Symfony\Component\Console\Command\Command->run()
#13 /var/www/nextcloud/apps/bookmarks/vendor/symfony/console/Application.php(1009): OC\Core\Command\Base->run()
#14 /var/www/nextcloud/apps/bookmarks/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand()
#15 /var/www/nextcloud/apps/bookmarks/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun()
#16 /var/www/nextcloud/lib/private/Console/Application.php(215): Symfony\Component\Console\Application->run()
#17 /var/www/nextcloud/console.php(100): OC\Console\Application->run()
#18 /var/www/nextcloud/occ(11): require_once('/var/www/nextcl...')

tarradmac · 2021-06-21T06:28:42Z

Comment out the point suggested by @ShinjiLE helps getting the indexing started but after indexing a lot of files and users with groupfolders enabled I get the following error:

An unhandled exception has been thrown:
Error: Call to a member function getOwner() on null in /var/www/nextcloud/lib/private/Share20/Manager.php:1651
Stack trace:
#0 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/LocalFilesService.php(163): OC\Share20\Manager->getAccessList()
#1 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(795): OCA\Files_FullTextSearch\Service\LocalFilesService->getShareUsersFromFile()
#2 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(725): OCA\Files_FullTextSearch\Service\FilesService->updateShareNames()
#3 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(699): OCA\Files_FullTextSearch\Service\FilesService->updateDocumentAccess()
#4 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(680): OCA\Files_FullTextSearch\Service\FilesService->updateFilesDocumentFromFile()
#5 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(571): OCA\Files_FullTextSearch\Service\FilesService->updateFilesDocument()
#6 /var/www/nextcloud/apps/files_fulltextsearch/lib/Provider/FilesProvider.php(288): OCA\Files_FullTextSearch\Service\FilesService->generateDocument()
#7 /var/www/nextcloud/apps/fulltextsearch/lib/Service/IndexService.php(317): OCA\Files_FullTextSearch\Provider\FilesProvider->fillIndexDocument()
#8 /var/www/nextcloud/apps/fulltextsearch/lib/Service/IndexService.php(204): OCA\FullTextSearch\Service\IndexService->indexDocuments()
#9 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(410): OCA\FullTextSearch\Service\IndexService->indexProviderContentFromUser()
#10 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(273): OCA\FullTextSearch\Command\Index->indexProvider()
#11 /var/www/nextcloud/apps/bookmarks/vendor/symfony/console/Command/Command.php(255): OCA\FullTextSearch\Command\Index->execute()
#12 /var/www/nextcloud/core/Command/Base.php(169): Symfony\Component\Console\Command\Command->run()
#13 /var/www/nextcloud/apps/bookmarks/vendor/symfony/console/Application.php(1009): OC\Core\Command\Base->run()
#14 /var/www/nextcloud/apps/bookmarks/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand()
#15 /var/www/nextcloud/apps/bookmarks/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun()
#16 /var/www/nextcloud/lib/private/Console/Application.php(215): Symfony\Component\Console\Application->run()
#17 /var/www/nextcloud/console.php(100): OC\Console\Application->run()
#18 /var/www/nextcloud/occ(11): require_once('/var/www/nextcl...')

Looks a lot like: nextcloud/server#15074

Hi,
The same here!!

escribana · 2021-06-29T14:08:29Z

Thanks @ShinjiLE the quickfix works here too!! Are there any news about the bug?

skynick11 · 2021-07-04T14:50:36Z

this app is not alive, isn't it?

buzz-tee · 2021-07-11T12:17:34Z

Maybe some simple type fixing should be considered here. Otherwise the same issues might surface anywhere, not "only" during debug(x) call.

You might apply this diff to files_fulltextsearch/lib/Model/MountPoint.php:

--- MountPoint.orig.php	2021-07-11 12:14:05.690177923 +0000
+++ MountPoint.php	2021-07-11 12:13:30.439026756 +0000
@@ -100,7 +100,7 @@
 	 * @return bool
 	 */
 	public function isGlobal(): bool {
-		return $this->global;
+		return $this->global === TRUE;
 	}
 
 	/**
@@ -119,7 +119,7 @@
 	 * @return array
 	 */
 	public function getGroups(): array {
-		return $this->groups;
+		return $this->groups ? $this->groups : array();
 	}
 
 	/**
@@ -138,7 +138,7 @@
 	 * @return array
 	 */
 	public function getUsers(): array {
-		return $this->users;
+		return $this->users ? $this->users : array();
 	}
 
 	/**

teambvd · 2021-07-15T23:37:14Z

That diff fixes it for me!

D3nnis3n · 2021-07-18T06:45:48Z

Comment out the point suggested by @ShinjiLE helps getting the indexing started but after indexing a lot of files and users with groupfolders enabled I get the following error:

An unhandled exception has been thrown:
Error: Call to a member function getOwner() on null in /var/www/nextcloud/lib/private/Share20/Manager.php:1651
Stack trace:
#0 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/LocalFilesService.php(163): OC\Share20\Manager->getAccessList()
#1 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(795): OCA\Files_FullTextSearch\Service\LocalFilesService->getShareUsersFromFile()
#2 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(725): OCA\Files_FullTextSearch\Service\FilesService->updateShareNames()
#3 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(699): OCA\Files_FullTextSearch\Service\FilesService->updateDocumentAccess()
#4 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(680): OCA\Files_FullTextSearch\Service\FilesService->updateFilesDocumentFromFile()
#5 /var/www/nextcloud/apps/files_fulltextsearch/lib/Service/FilesService.php(571): OCA\Files_FullTextSearch\Service\FilesService->updateFilesDocument()
#6 /var/www/nextcloud/apps/files_fulltextsearch/lib/Provider/FilesProvider.php(288): OCA\Files_FullTextSearch\Service\FilesService->generateDocument()
#7 /var/www/nextcloud/apps/fulltextsearch/lib/Service/IndexService.php(317): OCA\Files_FullTextSearch\Provider\FilesProvider->fillIndexDocument()
#8 /var/www/nextcloud/apps/fulltextsearch/lib/Service/IndexService.php(204): OCA\FullTextSearch\Service\IndexService->indexDocuments()
#9 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(410): OCA\FullTextSearch\Service\IndexService->indexProviderContentFromUser()
#10 /var/www/nextcloud/apps/fulltextsearch/lib/Command/Index.php(273): OCA\FullTextSearch\Command\Index->indexProvider()
#11 /var/www/nextcloud/apps/bookmarks/vendor/symfony/console/Command/Command.php(255): OCA\FullTextSearch\Command\Index->execute()
#12 /var/www/nextcloud/core/Command/Base.php(169): Symfony\Component\Console\Command\Command->run()
#13 /var/www/nextcloud/apps/bookmarks/vendor/symfony/console/Application.php(1009): OC\Core\Command\Base->run()
#14 /var/www/nextcloud/apps/bookmarks/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand()
#15 /var/www/nextcloud/apps/bookmarks/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun()
#16 /var/www/nextcloud/lib/private/Console/Application.php(215): Symfony\Component\Console\Application->run()
#17 /var/www/nextcloud/console.php(100): OC\Console\Application->run()
#18 /var/www/nextcloud/occ(11): require_once('/var/www/nextcl...')

Looks a lot like: nextcloud/server#15074

Getting the same over here, even after buzz-tees fix. Anyone got a fix for this?

teambvd · 2021-07-18T15:05:05Z

Group folders elasticsearch indexing is still broken, but that's a separate issue from this one imo - the null errors were returned due to files existing, but in a deleted state, which the diff handles.

Group folders is a separate permissions set, and given that, I'd probably create a new issue for it, referencing this ones fix. Thatll at least give them a good starting point ince the dev has some time to work on it 👍

tofuSCHNITZEL · 2021-07-24T16:24:56Z

I also get the "Call to a member function getOwner() on null in /var/www/nextcloud/lib/private/Share20/Manager.php:1651" error...
but I have group folder indexing disabled... any tipps?

JanBartels · 2021-08-06T19:24:11Z

In line /var/www/nextcloud/lib/private/Share20/Manager.php:1651 I've added an additional check on null on the object itself:

                        $path = array_shift($nodes);
                        if ($path === null || $path->getOwner() === null) {
                                return [];
                        }

This prevents the exception though I'm not yet sure that the indexing is correct.

Omaha2002 · 2021-08-15T17:54:18Z

In line /var/www/nextcloud/lib/private/Share20/Manager.php:1651 I've added an additional check on null on the object itself:
                        $path = array_shift($nodes);
                        if ($path === null || $path->getOwner() === null) {
                                return [];
                        }
This prevents the exception though I'm not yet sure that the indexing is correc

I can confirm that this works.

danielmanser · 2021-08-15T19:17:23Z

In line /var/www/nextcloud/lib/private/Share20/Manager.php:1651 I've added an additional check on null on the object itself:
                        $path = array_shift($nodes);
                        if ($path === null || $path->getOwner() === null) {
                                return [];
                        }
This prevents the exception though I'm not yet sure that the indexing is correct.

I can also confirm this works on 21.0.4.

solracsf · 2021-09-13T12:06:47Z

@JanBartels mind to make a PR for review on it?

JanBartels · 2021-09-14T17:37:36Z

@acsfer: I don't know how to make the PR correctly without loosing the link to this issue as the modified file is a part of another repo (https://github.com/nextcloud/server). Please advise.

solves nextcloud/files_fulltextsearch#125

This was referenced Jun 3, 2021

Fulltext search broken with groupfolders enabled. nextcloud/fulltextsearch#634

Closed

"TypeError: Return value of OCA\Files_FullTextSearch\Model\MountPoint::isGlobal() must be of the type bool" nextcloud/fulltextsearch_elasticsearch#147

Closed

skynick11 mentioned this issue Jun 21, 2021

Unhandled Exception: Return value of OCA\Files_FullTextSearch\Model\MountPoint::isGlobal() must be of the type bool, null returned in /var/snap/nextcloud/28088/nextcloud/extra-apps/files_fulltextsearch/lib/Model/MountPoint.php:103 #127

Closed

escribana mentioned this issue Jul 6, 2021

FullTextSearch with ElasticSearch doesn't work on NC 21 snap nextcloud-snap/nextcloud-snap#1765

Closed

Omaha2002 mentioned this issue Aug 15, 2021

Fulltextsearch indexing error /lib/private/Share20/Manager.php:1651 #133

Open

Omaha2002 mentioned this issue Aug 16, 2021

Error while creating index (Error: Call to a member function getOwner() on null in /var/www/nextcloud/lib/private/Share20/Manager.php:1651) nextcloud/fulltextsearch#652

Open

solracsf added 0. Needs triage bug good first issue labels Sep 15, 2021

solracsf changed the title ~~occ fulltextsearch:index throws NULL Pointer on isGlobal~~ occ fulltextsearch:index throws NULL Pointer on isGlobal Sep 15, 2021

JanBartels added a commit to JanBartels/server that referenced this issue Oct 13, 2021

Patch for NULL-pointer exception

07c167e

solves nextcloud/files_fulltextsearch#125

JanBartels mentioned this issue Oct 13, 2021

Patch for NULL-pointer exception nextcloud/server#29224

Closed

kesselb mentioned this issue Oct 18, 2021

Catch null path in share manager nextcloud/server#29304

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`occ fulltextsearch:index` throws NULL Pointer on `isGlobal` #125

`occ fulltextsearch:index` throws NULL Pointer on `isGlobal` #125

bronnertm commented May 17, 2021

tarradmac commented May 18, 2021 •

edited

Loading

jurgenhaas commented May 19, 2021

ShinjiLE commented May 19, 2021 •

edited

Loading

g-d-d-h commented Jun 2, 2021

thomasgg23 commented Jun 4, 2021

redRolf commented Jun 15, 2021 •

edited

Loading

Omaha2002 commented Jun 20, 2021 •

edited

Loading

tarradmac commented Jun 21, 2021

escribana commented Jun 29, 2021

skynick11 commented Jul 4, 2021

buzz-tee commented Jul 11, 2021 •

edited

Loading

teambvd commented Jul 15, 2021

D3nnis3n commented Jul 18, 2021 •

edited

Loading

teambvd commented Jul 18, 2021

tofuSCHNITZEL commented Jul 24, 2021

JanBartels commented Aug 6, 2021

Omaha2002 commented Aug 15, 2021

danielmanser commented Aug 15, 2021

solracsf commented Sep 13, 2021

JanBartels commented Sep 14, 2021

occ fulltextsearch:index throws NULL Pointer on isGlobal #125

occ fulltextsearch:index throws NULL Pointer on isGlobal #125

Comments

bronnertm commented May 17, 2021

tarradmac commented May 18, 2021 • edited Loading

jurgenhaas commented May 19, 2021

ShinjiLE commented May 19, 2021 • edited Loading

g-d-d-h commented Jun 2, 2021

thomasgg23 commented Jun 4, 2021

redRolf commented Jun 15, 2021 • edited Loading

Omaha2002 commented Jun 20, 2021 • edited Loading

tarradmac commented Jun 21, 2021

escribana commented Jun 29, 2021

skynick11 commented Jul 4, 2021

buzz-tee commented Jul 11, 2021 • edited Loading

teambvd commented Jul 15, 2021

D3nnis3n commented Jul 18, 2021 • edited Loading

teambvd commented Jul 18, 2021

tofuSCHNITZEL commented Jul 24, 2021

JanBartels commented Aug 6, 2021

Omaha2002 commented Aug 15, 2021

danielmanser commented Aug 15, 2021

solracsf commented Sep 13, 2021

JanBartels commented Sep 14, 2021

`occ fulltextsearch:index` throws NULL Pointer on `isGlobal` #125

`occ fulltextsearch:index` throws NULL Pointer on `isGlobal` #125

tarradmac commented May 18, 2021 •

edited

Loading

ShinjiLE commented May 19, 2021 •

edited

Loading

redRolf commented Jun 15, 2021 •

edited

Loading

Omaha2002 commented Jun 20, 2021 •

edited

Loading

buzz-tee commented Jul 11, 2021 •

edited

Loading

D3nnis3n commented Jul 18, 2021 •

edited

Loading