allow setting s3 concurrency, proxy, timeout, uploadPartSize, putSizeLimit, version, and verify_bucket_exists #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebot
commented
Jul 29, 2024
This was referenced Jul 29, 2024
jessebot
force-pushed
the
add-missing-s3-variables
branch
from
c355acb to
040b741
Compare
joshtrichards
added
enhancement
feature: auto config (environment variables)
jessebot
commented
Sep 20, 2024
Comment on lines
+195
to
+285
| - `OBJECTSTORE_S3_CONCURRENCY` (default: `5`) defines the maximum number of concurrent multipart uploads | ||
| - `OBJECTSTORE_S3_PROXY` (default: `false`) | ||
| - `OBJECTSTORE_S3_TIMEOUT` (default: `15`) | ||
| - `OBJECTSTORE_S3_UPLOADPARTSIZE` (default: `524288000`) | ||
| - `OBJECTSTORE_S3_PUTSIZELIMIT` (default: `104857600`) | ||
| - `OBJECTSTORE_S3_VERSION` (default: `latest`) | ||
| - `OBJECTSTORE_S3_VERIFY_BUCKET_EXISTS` (default: `true`) |
There was a problem hiding this comment.
do we also want to change these to "not set by default"? I can also understand keeping the defaults here, just so people don't have to cross reference with the nextcloud/server docs. Up to you, happy to accommodate either :)
|
@joshtrichards wanted to gently follow up and ask if anything else is needed here? |
|
@J0WI or @joshtrichards can I ask if there's anything else needed here to get this merged into the default branch? Sorry to be a pest. I just want to make sure this gets merged so we can support it in the helm chart properly. |
…Limit, version, and verify_bucket_exists Signed-off-by: jessebot <[email protected]>
Signed-off-by: Jesse Hitch <[email protected]>
jessebot
force-pushed
the
add-missing-s3-variables
branch
from
10d6edd to
2b545ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing S3 related environment variables. Fixes #2270
Per the docs here's the missing supported S3 parameters:
concurrencydefaults to 5 [Note: This defines the maximum number of concurrent multipart uploads]proxydefaults to falsetimeoutdefaults to 15uploadPartSizedefaults to 524288000putSizeLimitdefaults to 104857600versiondefaults to latestverify_bucket_existsdefaults to true [Note: Setting this to false after confirming the bucket has been created may provide a performance benefit, but may not be possible in multibucket scenarios.]This also helps us get ready to merge nextcloud/helm#614 downstream 🙏
Let me know if you need anything else :)