Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show received share information in share view #7373

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Show received share information in share view #7373

wants to merge 17 commits into from
+189 −33

Conversation

claucambra
Copy link
Collaborator

Screenshot 2024-10-21 at 02 09 40

Closes #3096

@claucambra
Add displayFileOwner property to ShareModel
c62588b 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add fileOwnerDisplayName property to ShareModel
77c6dd6 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Set if the file owner should be displayed and the file owner display …
b687f1b 
…name on propfind in sharemodel

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add sharedWithMe-related properties to sharemodel
4fdac39 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Also fetch shared with me share on target path
a72f23a 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
When handling fetched shares, record shared-with-me related informati…
cf0dd27 
…on in sharemodel properties

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Display file owner information (if not self) in share view
fce1304 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Display shared with me file's share expiry in share view if relevant
cf36ab9 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Display share owner rather than file owner (this is more relevant to …
aa7be97 
…user)

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Bolden string showing who owns the share that was shared with me
88a2904 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Convert ImageProvider in an async image provider using an internal im…
896e61a 
…age response

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add ability to fetch remote server avatars in usermodel avatar ImageR…
d479c13 
…esponse

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Add shareOwnerAvatar property to ShareModel
cec4970 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Build shareOwnerAvatar image provider string when handling sharedWith…
7ff1d01 
…Me share in ShareModel

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra
Display image for sharedWithMe share owner in share view
d7f7d94 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra added the feature: 👥 sharing Sharing dialog and functionalities. label Oct 20, 2024
@claucambra claucambra added this to the 3.15.0 milestone Oct 20, 2024
@claucambra claucambra self-assigned this Oct 20, 2024
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7373-6610f2ad38794364b367a7a126e1751d4b6857d8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
18.8% Coverage on New Code (required ≥ 80%)
39 New Code Smells (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

At least 1 approving review is required to merge this pull request.

Assignees

@claucambra claucambra

Labels
feature: 👥 sharing Sharing dialog and functionalities.
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.

Show expiration date on receiving shares
2 participants
@claucambra @nextcloud-desktop-bot