[Bug]: nextcloudcmd prejudiced against users named david

[davidc]

⚠️ Before submitting, please verify the following: ⚠️

• This is a bug, not a question or a configuration issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
• I agree to follow Nextcloud's Code of Conduct

Bug description

Following upgrade, nextcloudcmd has begun refusing to sync with the error

Error! Please specify only the base URL of your host with username and password. Example:
http(s)://username:[email protected]

Investigating the source finds this naive substring check in src/cmd/cmd.cpp line 348:

    if (options.target_url.contains("/webdav", Qt::CaseInsensitive) || options.target_url.contains("/dav", Qt::CaseInsensitive)) {

Naturally, since my username is david, the string nextcloudcmd -s /home/david/Documents/ 'https://[email protected]' contains the substring /dav

Steps to reproduce

1. Have a username that begins dav or webdav
2. Try to sync with nextcloudcmd

Expected behavior

I should not have to change my username in order to sync.

Which files are affected by this bug

n/a

Operating system

Linux

Which version of the operating system you are running.

Debian 12

Package

Distro package manager

Nextcloud Server version

29.0.7

Nextcloud Desktop Client version

3.7.3git

Is this bug present after an update or on a fresh install?

Updated to a major version (ex. 3.3.6 to 3.4.0)

Are you using the Nextcloud Server Encryption module?

Encryption is Enabled

Are you using an external user-backend?

• Default internal user-backend
• LDAP/ Active Directory
• SSO - SAML
• Other

Nextcloud Server logs

No response

Additional info

No response

[unknownuserisknown]

This is fantastic. Haven't giggled this much about a bug in a long time.

[claucambra]

Hi @davidc thanks for bringing this up. I promise we do not have any issues with Davids!

I have pushed #7286 to fix this problem