Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Various shades of grey in darkmode #7037

Open
AndyScherzinger opened this issue Aug 27, 2024 · 9 comments
Open

[Bug]: Various shades of grey in darkmode #7037

AndyScherzinger opened this issue Aug 27, 2024 · 9 comments
Labels
Milestone

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 27, 2024

Might be on purpose, hence close if n/a

Sync tab Connection settings tab Settings win11 settings example
2024-08-27 17_01_54-NVIDIA GeForce Overlay 2024-08-27 17_02_04-NVIDIA GeForce Overlay 2024-08-27 17_02_25-Nextcloud-Einstellungen 2024-08-27 17_00_59-Einstellungen
2024-09-08 18_33_13- Bug _ Various shades of grey in darkmode · Issue #7037 · nextcloud_desktop – Mo 2024-09-08 18_26_49-NVIDIA GeForce Overlay 2024-09-08 18_31_34- Bug _ Various shades of grey in darkmode · Issue #7037 · nextcloud_desktop – Mo
  • various grey tones for the main content area
  • slightly different size/color on checkboyes and radio buttons
@AndyScherzinger AndyScherzinger added this to the 3.14.0 milestone Aug 27, 2024
@mgallien
Copy link
Collaborator

mgallien commented Aug 28, 2024

main dialog screenshot using more native styling with dark mode (Fusion qml style)
image

set status
image

this was done by using #6980
there is an issue with the Windows native QML style
this style should look more native but is not working with dark mode
I tried to fix this but that may be a lot of work

@mgallien

This comment was marked as outdated.

@mgallien
Copy link
Collaborator

with better native style on Windows and a couple more small improvements
image
image
image

@AndyScherzinger
Copy link
Member Author

Nice improvements @mgallien 🤩

@mgallien
Copy link
Collaborator

I am unsure what to do with the QML user interfaces
should we stay with Fusion non native but looking good in bright and dark mode ?
should we go with native Windows style and spend a big effort trying to make it work in dark mode ?

I can provide bright mode screenshots to help

@AndyScherzinger @jancborchardt

@mgallien
Copy link
Collaborator

Fusion bright mode
image

Windows bright mode
image

@jancborchardt
Copy link
Member

@mgallien we should always prefer to have it as native as possible on all platforms. In the 2 screenshots, besides some bugs in the Windows version that have to be fixed, there is almost no discernible difference, and both can look more native.

Another example in settings, the tabs don’t look like standard (more like 2 buttons?) and the line containers for settings groups look quite dated:
image

@mgallien
Copy link
Collaborator

I will (but in the make UI more native PR) record a video. I would ping design team there.
That should make differences more obvious.

Regarding the frames in the settings dialog, I need to investigate why they look so bad by default. I do not think we override or customize anything there.

@mgallien
Copy link
Collaborator

regarding the frames and generally the settings
please have a look at the screenshots in #7051
I just forgot to left align a single label and fixed after the screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 👓 Design review
Development

No branches or pull requests

4 participants
@mgallien @jancborchardt @AndyScherzinger and others