diff --git a/src/gui/filedetails/sharemodel.cpp b/src/gui/filedetails/sharemodel.cpp index 146339b50efb..e755718de8bd 100644 --- a/src/gui/filedetails/sharemodel.cpp +++ b/src/gui/filedetails/sharemodel.cpp @@ -63,10 +63,9 @@ QString createRandomPassword() RAND_bytes(unsignedCharArray.data(), numChars); - for (auto i = 0; i < numChars; i++) { - auto byte = unsignedCharArray[i]; - byte %= asciiRange + 1; - byte += asciiMin; + for (const auto newChar : unsignedCharArray) { + // Ensure byte is within asciiRange + const auto byte = (newChar % (asciiRange + 1)) + asciiMin; passwd.append(byte); }