feat: delete stacks on remote shares

Signed-off-by: grnd-alt <[email protected]>

Author: grnd-alt

appinfo/routes.php

@@ -139,6 +139,7 @@
         ['name' => 'new_card#create', 'url' => '/api/v{apiVersion}/cards', 'verb' => 'POST'],
 
         ['name' => 'new_stack#create', 'url' => '/api/v{apiVersion}/stacks', 'verb' => 'POST'],
+		['name' => 'new_stack#delete', 'url' => '/api/v{apiVersion}/stacks/{stackId}/{boardId}', 'verb' => 'DELETE', 'defaults' => ['boardId' => null]],
 
 		['name' => 'Config#get', 'url' => '/api/v{apiVersion}/config', 'verb' => 'GET'],
 		['name' => 'Config#setValue', 'url' => '/api/v{apiVersion}/config/{key}', 'verb' => 'POST'],

lib/Controller/NewStackController.php

@@ -38,4 +38,21 @@ public function create(string $title, int $boardId, int $order = 0) {
 			return new DataResponse($stack);
 		};
 	}
+
+	#[NoAdminRequired]
+	#[PublicPage]
+	#[NoCSRFRequired]
+	#[RequestHeader(name: 'x-nextcloud-federation', description: 'Set to 1 when the request is performed by another Nextcloud Server to indicate a federation request', indirect: true)]
+	public function delete(int $stackId, ?int $boardId = null) {
+		if ($boardId) {
+			$board = $this->boardService->find($boardId, false);
+			if ($board->getExternalId()) {
+				$result = $this->externalBoardService->deleteStackOnRemote($board, $stackId);
+				return new DataResponse($result);
+			}
+		}
+		$result = $this->stackService->delete($stackId);
+		return new DataResponse($result);
+	}
+
 }

lib/Federation/DeckFederationProxy.php

@@ -108,6 +108,9 @@ public function get(string $cloudId, string $shareToken, string $url, array $par
 	public function post(string $cloudId, string $shareToken, string $url, array $params = []):IResponse {
 		return $this->request("post", $cloudId, $shareToken, $url, $params);
 	}
+	public function delete(string $cloudId, string $shareToken, string $url, array $params = []):IResponse {
+		return $this->request("delete", $cloudId, $shareToken, $url, $params);
+	}
 	public function getOCSData(IResponse $response, array $allowedStatusCodes = [Http::STATUS_OK]): array {
 		if (!in_array($response->getStatusCode(), $allowedStatusCodes, true)) {
 			$this->logUnexpectedStatusCode(__METHOD__, $response->getStatusCode());

lib/Service/ExternalBoardService.php

@@ -96,4 +96,13 @@ public function createStackOnRemote(
 		$stack = $this->proxy->getOcsData($resp);
 		return $this->localizeRemoteStacks([$stack], $localBoard)[0];
 	}
+
+    public function deleteStackOnRemote(Board $localBoard, int $stackId): array {
+       $shareToken = $localBoard->getShareToken();
+       $participantCloudId = $this->cloudIdManager->getCloudId($this->userId, null);
+       $ownerCloudId = $this->cloudIdManager->resolveCloudId($localBoard->getOwner());
+       $url = $ownerCloudId->getRemote() . "/ocs/v2.php/apps/deck/api/v1.0/stacks/" . $stackId;
+       $resp = $this->proxy->delete($participantCloudId->getId(), $shareToken, $url, []);
+       return $this->proxy->getOcsData($resp);
+    }
 }

lib/Service/StackService.php

@@ -225,7 +225,7 @@ public function delete(int $id): Stack {
 		$stack = $this->stackMapper->update($stack);
 
 		$this->activityManager->triggerEvent(
-			ActivityManager::DECK_OBJECT_BOARD, $stack, ActivityManager::SUBJECT_STACK_DELETE
+			ActivityManager::DECK_OBJECT_BOARD, $stack, ActivityManager::SUBJECT_STACK_DELETE, [], $this->permissionService->getUserId()
 		);
 		$this->changeHelper->boardChanged($stack->getBoardId());
 		$this->eventDispatcher->dispatchTyped(new BoardUpdatedEvent($stack->getBoardId()));

src/services/StackApi.js

@@ -97,11 +97,11 @@ export class StackApi {
 			})
 	}
 
-	deleteStack(stackId) {
-		return axios.delete(this.url(`/stacks/${stackId}`))
+	deleteStack(stackId, boardId) {
+		return axios.delete(this.ocsUrl(`/stacks/${stackId}/${boardId}`))
 			.then(
 				(response) => {
-					return Promise.resolve(response.data)
+					return Promise.resolve(response.data.ocs.data)
 				},
 				(err) => {
 					return Promise.reject(err)

src/store/stack.js

@@ -101,7 +101,7 @@ export default {
 				})
 		},
 		deleteStack({ commit }, stack) {
-			apiClient.deleteStack(stack.id)
+			apiClient.deleteStack(stack.id, stack.boardId)
 				.then((stack) => {
 					commit('deleteStack', stack)
 					commit('moveStackToTrash', stack)