-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when installing dev release 3.27.0 #12253
Comments
Confirmed. I can trigger this on-demand as well, without doing a new install, by trying to add another account in latest Dev from F-Droid. |
@alperozturk96 @tobiasKaminsky I suspect this comes from bumping the target sdk to 34 |
Yes its related with targetSDK 34 when we receive broadcast we need to specify explicitly. I will create PR asap. |
@exstntlmsnthrp Could you try with this branch? |
@AndyScherzinger We need to check Android-library as well, fyi. I will check it. |
@alperozturk96 No, that branch also fails. Here's the debug:
|
@AndyScherzinger @tobiasKaminsky We are using HWSecurity library and obviously even latest version 4.4.0 (24 Mar 2021) not handling broadcast receiver for Android 14. We need to fork this library and update the codebase if this library so vital or we can get rid of this library. What do you think? Issue created in their Github page |
HWSecurity is used for 2fa during login. |
Can we fork and use it as AAR file? |
Given zero responses in hwsecurity-sdk/hwsecurity#5 I suppose we kind of have to I fear. But looping in @dschuermann for feedback. Given it breaks Android 14 we either
So to not loose time @alperozturk96 is it easily possible to fork and build ourselves - just in case we have to go down that road, fingers crossed we don't? However see #8933 4.4.0 is broken, so we would need to fix it for the version we use. |
Fix is simple we are just going to add one more parameter. It's my prediction, if some other things not surprise us. Or basically we can reduce targetSDKLevel to 33. Which version we are using exactly? 4.3.0? |
Turns out we already did have to fork... |
Found the same :) |
😆 |
Great I will create PR with fix asap |
Awesome finding btw @alperozturk96 👍 |
Hey, yeah sorry, hwsecurity development is frozen right now. |
Hi @dschuermann thanks a lot for the feedback, highly appreciate it. Hope all is well for you, no worries about it - yet good to know. Great work you did in creating this library is very much appreciated 🙏 |
@exstntlmsnthrp can you try this #12263 (comment) ? Many thanks for your help! |
Fixes crash for me. |
@tobiasKaminsky Yes! I can confirm that QA version works as expected and I successfully logged into my NC27 instance without any problems. Thank you and I'm glad to help test. It's the least I can do, since I have no dev skills. |
Steps to reproduce
This is a new report as requested in #12229.
Expected behaviour
Please see below or #12229
Actual behaviour
See previous
Android version
14 - GrapheneOS
Device brand and model
Pixel 7 Pro
Stock or custom OS?
Custom (explain in "additional information")
Nextcloud android app version
3.27.0
Nextcloud server version
27
Using a reverse proxy?
No
Android logs
No response
Server error logs
No response
Additional information
I don't know if you want a new bug opened for this or if it's appropriate to post here. I've installed the release candidate (Android 14, GrapheneOS, Pixel 7 Pro) from GitHub and I've two issues. The first is it conflicts with the previous release candidate and I had to uninstall the previous in order to update. Secondly, the app will not open. Keeps crashing with the following log.
App information
com.nextcloud.client
30270051
generic
Device information
google
cheetah
Pixel 7 Pro
UP1A.231105.003
cheetah
Firmware
34
14
2023112900
The text was updated successfully, but these errors were encountered: