Skip to content

[stable32] fix: only write activites for actual public uploads#2459

Merged
miaulalala merged 2 commits intostable32from
backport/2431/stable32
Apr 9, 2026
Merged

[stable32] fix: only write activites for actual public uploads#2459
miaulalala merged 2 commits intostable32from
backport/2431/stable32

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot bot commented Mar 16, 2026

Backport of #2431

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Currently, any file activity without a proper session is interpreted to be a public upload.
Now, the share token is compared and the activity is only written when the share token belongs to a public folder

Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the backport/2431/stable32 branch from 3256cdf to 8b2821d Compare April 9, 2026 11:08
@miaulalala miaulalala marked this pull request as ready for review April 9, 2026 11:09
@miaulalala miaulalala enabled auto-merge April 9, 2026 11:10
@cypress
Copy link
Copy Markdown

cypress bot commented Apr 9, 2026

Activity    Run #3559

Run Properties:  status check passed Passed #3559  •  git commit 0cb97ff254: [stable32] fix: only write activites for actual public uploads
Project Activity
Branch Review backport/2431/stable32
Run status status check passed Passed #3559
Run duration 02m 25s
Commit git commit 0cb97ff254: [stable32] fix: only write activites for actual public uploads
Committer backportbot[bot]
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 9
View all changes introduced in this branch ↗︎

@miaulalala miaulalala merged commit cfdeacc into stable32 Apr 9, 2026
60 of 67 checks passed
@miaulalala miaulalala deleted the backport/2431/stable32 branch April 9, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants