Step2 - 문자열 계산기 #1151
Open
Step2 - 문자열 계산기 #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujusy
requested changes
Jun 12, 2023
| private fun divide(first: Int, second: Int): Int { | ||
| return first / second | ||
| } | ||
| } |
There was a problem hiding this comment.
intellji에서 new line 설정이 가능하니 설정해두시면 좋습니다 :)
| return first * second | ||
| } | ||
|
|
||
| private fun divide(first: Int, second: Int): Int { |
There was a problem hiding this comment.
5/2 일 경우에는 어떤 결과값이 나올까요? 이 경우도 테스트로 작성해보면 좋을 것 같아요:)
Comment on lines
+4
to
+6
| if(input.isNullOrBlank()) { | ||
| throw IllegalArgumentException() | ||
| } |
There was a problem hiding this comment.
kotlin 의 ruquire를 사용해 볼 수 있어요 :)
|
|
||
| fun calcutateByString(input: String?): Int { | ||
| if(input.isNullOrBlank()) { | ||
| throw IllegalArgumentException() |
| if(input.isNullOrBlank()) { | ||
| throw IllegalArgumentException() | ||
| } | ||
| val splitedInput = input.split(" ") |
| throw IllegalArgumentException() | ||
| } | ||
| val splitedInput = input.split(" ") | ||
| var result: Int = splitedInput.first().toInt() |
|
|
||
| @Test | ||
| fun `예제 확인`() { | ||
| assertThat(Calculation().calcutateByString("2 + 3 * 4 / 2")) |
There was a problem hiding this comment.
여유가 있다면 @ParameterizedTest 를 이용해서 다양한 케이스에 대해 테스트를 해보면 좋을 것 같아요 :)
| @@ -0,0 +1,40 @@ | |||
| class Calculation { | |||
|
|
|||
| fun calcutateByString(input: String?): Int { | |||
There was a problem hiding this comment.
이를 직접 콘솔에서 실행해 볼 수 있는 main함수를 만들어보면 어떨까요? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step2 - 문자열 계산기 리뷰요청 드립니다.
Step1 실습 코드 페키지 이동 시키면서 추가 커밋이 발생했는데 아래 2개 파일은 무시해주세요.
(처음 리뷰시 전달 해주신 필요없는 주석 제거 이외에 수정 사항은 없습니다. )
Step 2 관련 리뷰요청을 위해 추가된 파일은 아래 2가지 입니다.