Skip to content

Commit 9ad91e8

Browse files
committed
refactor: collectingAndThen 사용하여 바로 반환
1 parent a8a84a8 commit 9ad91e8

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

src/main/java/nextstep/ladder/domain/Lines.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
package nextstep.ladder.domain;
22

33
import java.util.List;
4-
import java.util.stream.Collectors;
54
import java.util.stream.IntStream;
65

6+
import static java.util.stream.Collectors.collectingAndThen;
7+
import static java.util.stream.Collectors.toList;
8+
79
public class Lines {
810

911
private final List<Line> lines;
@@ -20,10 +22,9 @@ private void validate(List<Line> lines) {
2022
}
2123

2224
public static Lines of(int numberOfPlayers, int height) {
23-
List<Line> lines = IntStream.range(0, height)
25+
return IntStream.range(0, height)
2426
.mapToObj(i -> LineBuilder.buildWithRandomPoints(numberOfPlayers))
25-
.collect(Collectors.toList());
26-
return new Lines(lines);
27+
.collect(collectingAndThen(toList(), Lines::new));
2728
}
2829

2930
public int getHeight() {

src/main/java/nextstep/ladder/domain/Players.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
package nextstep.ladder.domain;
22

33
import java.util.List;
4-
import java.util.stream.Collectors;
54
import java.util.stream.IntStream;
65

6+
import static java.util.stream.Collectors.collectingAndThen;
7+
import static java.util.stream.Collectors.toList;
8+
79
public class Players {
810
private final List<Player> players;
911

@@ -19,11 +21,9 @@ private void validate(List<Player> players) {
1921
}
2022

2123
public static Players of(List<String> playerNames) {
22-
List<Player> players = IntStream.range(0, playerNames.size())
24+
return IntStream.range(0, playerNames.size())
2325
.mapToObj(index -> new Player(index, playerNames.get(index)))
24-
.collect(Collectors.toList());
25-
26-
return new Players(players);
26+
.collect(collectingAndThen(toList(), Players::new));
2727
}
2828

2929
public int count() {

0 commit comments

Comments
 (0)