-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails v7.1: Make sure the Trilogy MySQL adapter is identified and supported correctly #2221
Comments
(Trilogy can also be used by Rails 6 and 7.0) |
@hannahramadan: is it possible that this has been implemented only for Rails 7.1+? We have just tried to use NewRelic agent 9.12.0, Rails 7.0.8.4 and Trilogy 2.8.1, and while it did show up in the UI as in your screenshot, all the time spend on DB queries was attributed to Ruby and there were no MySQL queries shown... |
@gdubicki It may be possible since we have only tested on rails 7.1, but no new code was added for trilogy. It was already working via the already existing active record instrumentation, which should work for all rails versions. So I'm not sure exactly what could be going on with what you are describing. We can take a look again at running an app with trilogy to see if we can see anything unusual going on. In the meantime though, if you have additional details about that maybe helpful in our attempt to reproduce the problem, that would be appreciated! |
Can you re-open this issue ? We are facing the same issue mentioned by @gdubicki, even though the agent identifies the adapter correctly we have no MySQL trace on APM. We are using rails 7.1.4, new relic agent 9.15.0, trilogy 2.9.0, ruby 3.3.5. |
Thank you for letting us know, @rodolfoburla! We'll take another look. |
Work has been completed on this issue. |
More context here, queries are displayed on traces as ActiveRecord. But when looking at APM->Databases there is no MySql there, so looking at the source code I think it is missing to map Trilogy to MySql. |
@rodolfoburla, @gdubicki - Thank you and apologies for missing this the first time around! We've put together a branch that we think solves this issue and would love any feedback on it. To use, please update your gem 'newrelic_rpm', github: 'newrelic/newrelic-ruby-agent', branch: 'are_you_there_trilogy' |
@hannahramadan Thank you, we have tested and now the Database view has MySql again. Do you have any idea when it is going to be released? |
Thank you for testing, @rodolfoburla! We are planning a release the first week of December and will include this fix. I will follow up here when it is live. |
Thank you @hannahramadan, btw once it is released I think you should update the documentation here: https://docs.newrelic.com/docs/apm/agents/ruby-agent/getting-started/ruby-agent-requirements-supported-frameworks/#instance_details . |
Already production tested by GitHub and Shopify, GitHub's MySQL adapter Trilogy is available in Rails v7.1 as an out-of-the-box choice. We should ensure that Trilogy is correctly identified by our instrumentation.
Use rails 7.1.0.beta1 or EDGE to test with.
The text was updated successfully, but these errors were encountered: