You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed in #2870 which addressed #2869, our existing ViewComponent instrumentation had been making use of a private API which was well within its rights to change without us knowing about it. We also monkeypatch render_in instead of consuming the ActiveSupport notification generated by ViewComponent's own render_in method.
We ought to:
See if we can completely get out of the business of monkeypatching render_in and rely solely on the notification produced by original method and if not we should work with ViewComponent's maintainers to report our findings. At first glance, it looks like the big win that monkeypatching gives us over the notifications is that we are able to wrap the call in a rescue and generate a New Relic noticed error. Can we enhance ViewComponent's own error handling of render_in to include error information in the ActiveSupport notification?
Audit all existing ViewComponent API calls we make and comment on any uses of private APIs. These should all have very specific unit test coverage to give us early warnings when a new ViewComponent gem version is released, and they should all have corresponding GitHub issues created to remind us to work with the ViewComponent maintainers to evaluate options for moving away from using private APIs.
The text was updated successfully, but these errors were encountered:
As discussed in #2870 which addressed #2869, our existing ViewComponent instrumentation had been making use of a private API which was well within its rights to change without us knowing about it. We also monkeypatch
render_in
instead of consuming the ActiveSupport notification generated by ViewComponent's ownrender_in
method.We ought to:
render_in
and rely solely on the notification produced by original method and if not we should work with ViewComponent's maintainers to report our findings. At first glance, it looks like the big win that monkeypatching gives us over the notifications is that we are able to wrap the call in arescue
and generate a New Relic noticed error. Can we enhance ViewComponent's own error handling ofrender_in
to include error information in the ActiveSupport notification?The text was updated successfully, but these errors were encountered: