-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent the Agent from storing raw SQL queries in memory when "record_sql" is "off" or "obfuscated" #461
Comments
Comment added by Kevyn Ford in Aha! - View Snapshot agent build provided to customer for feedback. Moving this MMF to Nov to compensate for the feedback delay. |
Current approach in #559 has concerns, including breaking an underlying public API. Going to have to re-prioritize this for a future round of engineering work. |
Comment added by Kevyn Ford in Aha! - View Could not make the |
Will likely need another ~2 weeks of engineering time |
It looks like the Agent will currently store any full, raw SQL query that it detects until the end of the Tracer. At that point it checks the Agent's "record_sql" configuration and either obfuscates the query or drops it entirely. Unfortunately we've seen a few instances where customers have a huge number of large SQL queries being executed which causes the Agent to take up massive amounts of heap space over short periods.
Since the "record_sql" configuration doesn't prevent the raw queries from being stored in memory we don't have any good options of resolving the issue except by disabling the database instrumentation entirely.
Allowing the "record_sql" configuration to immediately affect the data that gets stored in memory, either by obfuscating that data first or dropping it entirely(based on the exact configuration), would give Support a path forward to prevent raw SQL query data from using memory space, if needed.
(Migrate to Jira)
The text was updated successfully, but these errors were encountered: