Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pekko HTTP support for scala 3 #2109

Open
kanderson250 opened this issue Oct 28, 2024 · 1 comment
Open

Add Pekko HTTP support for scala 3 #2109

kanderson250 opened this issue Oct 28, 2024 · 1 comment
Assignees
Labels
oct-dec qtr Represents proposed work item for the Oct-Dec quarter

Comments

@kanderson250
Copy link
Contributor

Currently our pekko-http module only supports scala 2.13. The verifier fails when run against scala 3 with a return type error:

* What went wrong:
Execution failed for task ':instrumentation:apache-pekko-http-2.13_1:verifyPass_org.apache.pekko_pekko-http_3_1.0.0'.
> A failure occurred while executing com.newrelic.agent.instrumentation.verify.VerifyWorkAction
   > Verification FAILED. Instrumentation module apache-pekko-http-2.13_1-1.0.jar SHOULD HAVE applied to org.apache.pekko:pekko-http_3:1.0.0 and did not. You may need to adjust the range "org.apache.pekko:pekko-http_3:[1.0.0,)".
     Verifier output:
     Creating user classloader with custom classpath:
        /Users/katherineanderson/.gradle/caches/modules-2/files-2.1/org.apache.pekko/pekko-http_3/1.0.0/1cffe16400f2af34f64d49bc01b273d24418158e/pekko-http_3-1.0.0.jar
        /Users/katherineanderson/.gradle/caches/modules-2/files-2.1/org.apache.pekko/pekko-stream_3/1.0.0/d58f72f26723277a57c17552a98039b5315b34cc/pekko-stream_3-1.0.0.jar
        /Users/katherineanderson/.gradle/caches/modules-2/files-2.1/org.apache.pekko/pekko-http-core_3/1.0.0/9cf150c9ae8d06dee07ae2aeb07e6ca1a370d9dd/pekko-http-core_3-1.0.0.jar
        /Users/katherineanderson/.gradle/caches/modules-2/files-2.1/org.apache.pekko/pekko-actor_3/1.0.0/f0f701830210c72d4e6ebdb6d6755ccb445ca01d/pekko-actor_3-1.0.0.jar
        /Users/katherineanderson/.gradle/caches/modules-2/files-2.1/com.typesafe/ssl-config-core_3/0.6.1/4a76ce60e5378b393be894f7ef22457140738f1b/ssl-config-core_3-0.6.1.jar
        /Users/katherineanderson/.gradle/caches/modules-2/files-2.1/org.apache.pekko/pekko-parsing_3/1.0.0/657145b6f79ccd0b325ec7e71fa81eec45655c7a/pekko-parsing_3-1.0.0.jar
        /Users/katherineanderson/.gradle/caches/modules-2/files-2.1/org.parboiled/parboiled_3/2.5.0/ded72f05d2fee6ae0eae2e872b69c51c15d3c0b3/parboiled_3-2.5.0.jar
        /Users/katherineanderson/.gradle/caches/modules-2/files-2.1/org.scala-lang/scala3-library_3/3.3.0/abe22d760d47702550c77c0fdd443f78ab2db582/scala3-library_3-3.3.0.jar
        /Users/katherineanderson/.gradle/caches/modules-2/files-2.1/org.apache.pekko/pekko-protobuf-v3_3/1.0.0/bb0f37e2c5223d42e7b83e73b1186afd903c1980/pekko-protobuf-v3_3-1.0.0.jar
        /Users/katherineanderson/.m2/repository/org/reactivestreams/reactive-streams/1.0.4/reactive-streams-1.0.4.jar
        /Users/katherineanderson/.gradle/caches/modules-2/files-2.1/org.scala-lang/scala-library/2.13.10/67c1afabaea9ba51321159e70a78515647e1b73d/scala-library-2.13.10.jar
        /Users/katherineanderson/.gradle/caches/modules-2/files-2.1/com.typesafe/config/1.4.2/4c40a633e7994cfb0354244efb6d03fcb11c3ecf/config-1.4.2.jar
     WeaveViolation{type=METHOD_RETURNTYPE_MISMATCH, clazz=org/apache/pekko/http/scaladsl/server/PathMatchers$RemainingPath$, method=apply(Lorg/apache/pekko/http/scaladsl/model/Uri$Path;)Lorg/apache/pekko/http/scaladsl/server/PathMatcher$Matched;}
     WeaveViolation{type=METHOD_RETURNTYPE_MISMATCH, clazz=org/apache/pekko/http/scaladsl/server/PathMatchers$Remaining$, method=apply(Lorg/apache/pekko/http/scaladsl/model/Uri$Path;)Lorg/apache/pekko/http/scaladsl/server/PathMatcher$Matched;}


Create a new pekko http module to fix the return type errors and add support for scala 3.

(Note, our pekko-http-core module already works for scala 3).

@workato-integration
Copy link

@kford-newrelic kford-newrelic added the oct-dec qtr Represents proposed work item for the Oct-Dec quarter label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oct-dec qtr Represents proposed work item for the Oct-Dec quarter
Projects
Status: In Quarter
Development

No branches or pull requests

2 participants