Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferSize for channels in runtime #665

Open
emil14 opened this issue May 31, 2024 · 1 comment
Open

BufferSize for channels in runtime #665

emil14 opened this issue May 31, 2024 · 1 comment

Comments

@emil14
Copy link
Collaborator

emil14 commented May 31, 2024

We have opportunity to set buffer size for channels (ports) in IR but we don't do that.

  1. Make sure it won't broke anything
  2. Figure out how to properly set it

About second part - we might try to somehow automatically calculate (e.g. based on amount of senders/receivers) or expose to user. Or even combine!

Related to #663 and #644

@emil14
Copy link
Collaborator Author

emil14 commented May 31, 2024

As we know from #644 in new design we have one queue for all senders. This design isn't perfect because we have a bottle-neck because of 2 reasons

  • slow receiver will slow down sending from sender and receiving by fast receivers
  • all senders share same queue so slow sending slows down other faster sendings ("sending" here is both actual sending and receiving by all receivers)

Obvious idea to scale this is to add more queues. One queue per fan-in

Each fan-in has N senders to 1 receiver. We could use that N as a buffer size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant