What's the chart version bump policy? Should I bump the chart version, or is that done automatically and/or in a later stage or the release process? Do you consider this a breaking change?

I saw that the secrets had a -secrets suffix, and services had sometimes -svc and sometimes -service infixes which I've also removed now. Again: there's no need to specify the resource kind in the name.

Do not merge this yet, the tests aren't yet working when removing the -secret suffix.

I cannot remove the -secret suffix from neuvector-controller-secret without the tests breaking. Might be something wrong with the tests. If someone could help me figure this out, it would be swell.

What I'm doing:

sed -i 's/neuvector-controller-secret/neuvector-controller/g' charts/core/templates/controller* test/deployment_test.go
cd test
go test

We will bump up the version when release.

However, we will not accept this patch. Having the resource kind in the name might not be necessary, it also doesn't hurt to have it. Extensive change like this will likely break the upgrade case.

Having the resource kind in the name might not be necessary, it also doesn't hurt to have it.

Quite alright. But can we please be consistent with it then? Let's add the resource kind to all names. And maybe we can remove the "pod" suffix from the non-pod resources. This too "does not hurt", but surely it's not a good thing to have a name that indicates the wrong kind...

Extensive change like this will likely break the upgrade case.

I'm happy to break this change into smaller parts, if you think that would be better.

@becitsthere What do you say? How do we best make the naming more consistent?