NVSHAS-9741: Dashboard: run as root instruction has typo on score imp…

…rovement panel
neuvector · Dec 30, 2024 · 29c6153 · 29c6153
1 parent a57a15a
commit 29c6153
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 14 deletions.
diff --git a/admin/webapp/websrc/app/common/constants/global.constant.ts b/admin/webapp/websrc/app/common/constants/global.constant.ts
@@ -121,7 +121,7 @@ export class GlobalConstant {
       KUBE: 'Kubernetes',
     },
     BOOLEAN_CRITERIA: {
-      TRUE: ['run_as_root_score', 'runAsPrivileged'],
+      TRUE: ['runAsRoot', 'runAsPrivileged'],
       FALSE: ['imageScanned', 'imageSigned'],
     },
     CRITERION_TYPE: {
@@ -211,7 +211,7 @@ export class GlobalConstant {
 
   public static CRITERIA_PATTERN = {
     NAME_ONLY: [
-      'run_as_root_score',
+      'runAsRoot',
       'runAsPrivileged',
       'allowPrivEscalation',
       'pspCompliance',

diff --git a/...al/score-improvement-general-list-item/score-improvement-general-list-item.component.html b/...al/score-improvement-general-list-item/score-improvement-general-list-item.component.html
@@ -116,22 +116,21 @@
     </p>
   </mat-expansion-panel>
   <mat-expansion-panel
-    [(expanded)]="expanded.run_as_root_score"
+    [(expanded)]="expanded.runAsRoot"
     *appDisplayControl="'improve_score_on_runasroot'"
     class="mat-elevation-z0"
     hideToggle>
     <mat-expansion-panel-header>
       <mat-panel-title>
         {{
-          'dashboard.improveScoreModal.summary.run_as_root_score.brief_1'
-            | translate
+          'dashboard.improveScoreModal.summary.runAsRoot.brief_1' | translate
         }}
       </mat-panel-title>
       <mat-panel-description class="justify-content-end mr-0">
         <div class="row align-items-center improvement-item-actions">
           <div class="col">
             <mat-icon>
-              {{ expanded.run_as_root_score ? 'expand_less' : 'expand_more' }}
+              {{ expanded.runAsRoot ? 'expand_less' : 'expand_more' }}
             </mat-icon>
           </div>
           <div class="col d-flex justify-content-end">
@@ -147,10 +146,7 @@
       </mat-panel-description>
     </mat-expansion-panel-header>
     <p>
-      {{
-        'dashboard.improveScoreModal.summary.run_as_root_score.advice_1'
-          | translate
-      }}
+      {{ 'dashboard.improveScoreModal.summary.runAsRoot.advice_1' | translate }}
     </p>
   </mat-expansion-panel>
   <mat-expansion-panel

diff --git a/...eral/score-improvement-general-list-item/score-improvement-general-list-item.component.ts b/...eral/score-improvement-general-list-item/score-improvement-general-list-item.component.ts
@@ -13,7 +13,7 @@ export class ScoreImprovementGeneralListItemComponent {
     serviceRisk: false,
     exposure: false,
     runAsPrivileged: false,
-    run_as_root_score: false,
+    runAsRoot: false,
     admissionControl: false,
   };
   get rawScore() {

diff --git a/...-run-as-root-containers-view/score-improvement-run-as-root-containers-view.component.html b/...-run-as-root-containers-view/score-improvement-run-as-root-containers-view.component.html
@@ -1,6 +1,6 @@
 <app-score-prediction-header
   message="{{
-    'dashboard.improveScoreModal.run_as_root_score.DESCRIPTION' | translate
+    'dashboard.improveScoreModal.runAsRoot.DESCRIPTION' | translate
   }}"
   [score]="score"
   [projectedScore]="projectedScore">

diff --git a/...nt-run-as-root-containers-view/score-improvement-run-as-root-containers-view.component.ts b/...nt-run-as-root-containers-view/score-improvement-run-as-root-containers-view.component.ts
@@ -72,7 +72,7 @@ export class ScoreImprovementRunAsRootContainersViewComponent
     this.containersService.getContainers().subscribe({
       next: workloads => {
         this.containers = workloads
-          .filter(this.run_as_root_scoreFilter)
+          .filter(this.runAsRootFilter)
           .filter(w => w.state !== 'exit' && !w.platform_role);
         this.containersService.displayContainers =
           this.containersService.formatScannedWorkloads(this.containers);
@@ -93,7 +93,7 @@ export class ScoreImprovementRunAsRootContainersViewComponent
       });
   }
 
-  private run_as_root_scoreFilter = (w: Workload) => {
+  private runAsRootFilter = (w: Workload) => {
     return (
       w.children &&
       w.children.length > 0 &&