Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Avoid rebuild on production #34

Open
ltetrel opened this issue Mar 3, 2022 · 2 comments
Open

Avoid rebuild on production #34

ltetrel opened this issue Mar 3, 2022 · 2 comments

Comments

@ltetrel
Copy link
Collaborator

ltetrel commented Mar 3, 2022

Currently, a binder submission is built from user/repo.git on neurolibre-test (compute canada) and then the image is pushed to our own registry on neurolibre-prod (mcgill). When the binder submission is sent on neurolibre-prod from fork roboneuro/repo.git, it is supposed to get the cached image and avoid docker re-building.
However because the repository name change (user/repo.git -> roboneurolibre/repo.git ) it is still trying to rebuild (but push is much faster because the layers already exists on registry).

@ltetrel
Copy link
Collaborator Author

ltetrel commented Mar 3, 2022

Suggestion was to use custom name for docker build, however binderhub uses repo link as an internal reference.

@ltetrel
Copy link
Collaborator Author

ltetrel commented Mar 3, 2022

An easier path would be to actually also launch and build test from roboneurolibre/repo.git and not user/repo.git anymore.
During review and test, whenever we trigger a roboneuro build notebooks through github, it will actually update its fork to get up-to-date version from user.
Not sure if roboneuro could support that @agahkarakuzu

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant