Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rolling mean filter #454

Open
niksirbi opened this issue Feb 28, 2025 · 5 comments · May be fixed by #459
Open

Add a rolling mean filter #454

niksirbi opened this issue Feb 28, 2025 · 5 comments · May be fixed by #459
Labels
enhancement New optional feature good first issue Good for newcomers

Comments

@niksirbi
Copy link
Member

We've had a rolling median filter for quite some time now, but we've neglected to also add a rolling mean filter that works the same way.

@stellaprins had a need for a rolling mean filter while working on #429, and ended up implementing it using np.convolve.

It should be simple to either:

  • add a mean_filter that works the same as median_filter
  • come up with a more general filtering function that can be made to return the mean or the median, depending on a keyword argument.

Once we implement this, we should also edit the eye movement example introduced by #429 to use our new shiny filter function.

@samradhi1684
Copy link

hi @niksirbi i think i can work on this issue. could you please assign it to me?

@cs7-shrey
Copy link

@niksirbi I would like to work on it!

@Spkap
Copy link

Spkap commented Mar 1, 2025

Hi, I’d like to work on this issue. Could you assign it to me? Thanks!

ArismitaM added a commit to ArismitaM/movement that referenced this issue Mar 3, 2025
ArismitaM added a commit to ArismitaM/movement that referenced this issue Mar 3, 2025
@ArismitaM ArismitaM linked a pull request Mar 3, 2025 that will close this issue
7 tasks
@niksirbi niksirbi linked a pull request Mar 3, 2025 that will close this issue
7 tasks
@niksirbi
Copy link
Member Author

niksirbi commented Mar 3, 2025

Thanks all for expressing interest in solving this issue.

Note that there is no need to be assigned to an issue to start working on it.
Instead we encourage contributors to open a draft pull request early in the process, so that others can see the approach you are taking. Just make sure to mention this issue in the pull request (e.g. "closes #issue-number").

Given that there are already two PRs proposing alternative solutions to this issue (#455 and #459), I would refrain from further duplicating effort on this one.

@Spkap
Copy link

Spkap commented Mar 3, 2025

Hi @niksirbi ,
Thanks for the clarification. Since PRs #455 and #459 are already addressing this issue, I’ll refrain from duplicating efforts.
However, if there’s any scope to improve or extend the existing PRs, I’d be happy to contribute. Let me know if that makes sense!

Best,
Sourabh Kapure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New optional feature good first issue Good for newcomers
Projects
Status: 🤔 Triage
Development

Successfully merging a pull request may close this issue.

4 participants