Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch compute_forward_vector_angle to return radian angles by default #427

Open
willGraham01 opened this issue Feb 21, 2025 · 0 comments · May be fixed by #445
Open

Switch compute_forward_vector_angle to return radian angles by default #427

willGraham01 opened this issue Feb 21, 2025 · 0 comments · May be fixed by #445
Labels
enhancement New optional feature

Comments

@willGraham01
Copy link
Contributor

willGraham01 commented Feb 21, 2025 •
edited
Loading

See https://github.com/neuroinformatics-unit/movement/pull/416/files#r1961522764

The compute_forward_vector_angle returns angles in degrees by default, but all our other functions return radians. For consistency, we should swap the default behaviour of this function too.

(Whilst we're at it, we might also want to address this other suggestion)
@willGraham01 willGraham01 added the enhancement New optional feature label Feb 21, 2025
@willGraham01 willGraham01 changed the title Switch to radian angles by default Switch compute_forward_vector_angle to return radian angles by default Feb 21, 2025
@willGraham01 willGraham01 linked a pull request Feb 27, 2025 that will close this issue
Open
7 tasks
@willGraham01 willGraham01 moved this from 🤔 Triage to 🚧 In Progress in movement progress tracker Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New optional feature
Projects
movement progress tracker
Status: 🚧 In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove toggles for signed angle computations neuroinformatics-unit/movement
1 participant
@willGraham01