Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validators to reduce code duplication between bboxes and poses #241

Open
sfmig opened this issue Jul 19, 2024 · 1 comment
Open
Labels
enhancement New optional feature

Comments

@sfmig
Copy link
Contributor

sfmig commented Jul 19, 2024

Is your feature request related to a problem? Please describe.
When implementing the ValidBBoxesDataset class we noticed there is some overlap with the ValidPosesDataset class.

Describe the solution you'd like
@niksirbi suggested defining a ValidMoveDataset base class which can validate what's shared across poses and bboxes. Then, ValidPosesDataset and ValidBBoxesDataset can inherit from the base, and only do the "extra" validations specific to each dataset type.

Describe alternatives you've considered
\

Additional context
\

@sfmig
Copy link
Contributor Author

sfmig commented Aug 28, 2024

We could consider just having one type of dataset with relaxed validation (just requiring time and space)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New optional feature
Projects
Status: 🤔 Triage
Development

No branches or pull requests

1 participant