Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default names for individuals if none are passed to pose dataset #217

Open
sfmig opened this issue Jun 12, 2024 · 5 comments
Open
Labels
enhancement New optional feature

Comments

@sfmig
Copy link
Contributor

sfmig commented Jun 12, 2024

Is your feature request related to a problem? Please describe.
For the poses dataset, if no individual names are passed we name them starting from individual_0.

For the bboxes dataset, we start with id_1 (following 1-based convention from MOT challenge).

With @niksirbi we discussed both should be consistent, and that id_1 could be nicer because it's less verbose. So we suggest to change to 1-based ID naming for pose data.

Describe the solution you'd like
If no individual names are passed by default, name them as id_1, id_2...

Describe alternatives you've considered
We could use 0-based indexing, but 1-based seems a lightly held standard at least in object tracking (MOT challenge).

Additional context
\

@sfmig sfmig added the enhancement New optional feature label Jun 12, 2024
@adamltyson
Copy link
Member

adamltyson commented Jun 12, 2024

Could 1-based indexing be slightly confusing in a Python environment? Could you end up with a situation where the 0th individual is named id_1?

@niksirbi
Copy link
Member

That's a fair point Adam. So we'd have to choose between a Python convention vs a MOT convention 🤷🏼

@niksirbi
Copy link
Member

I slightly lean towards the Python convention, just to minimise the possibility of off-by-one errors creeping in, so id_0, id_1, etc.?

@adamltyson
Copy link
Member

I also lean that way. If for no other reason than 100% of users will use Python, and some percentage <100 will be familiar with MOT.

@sfmig
Copy link
Contributor Author

sfmig commented Aug 27, 2024

For bboxes datasets the default name for individuals is now id_0, id_1,...

Instead for poses datasets it is individual_0, etc (see here)

We would like to make this consistent.

@sfmig sfmig moved this from 🤔 Triage to 📝 Todo in movement progress tracker Aug 27, 2024
@sfmig sfmig moved this from 📝 Todo to 🤔 Triage in movement progress tracker Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New optional feature
Projects
Status: 🤔 Triage
Development

No branches or pull requests

3 participants