Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animal names for anonymous users #35

Closed
anibalsolon opened this issue Feb 4, 2021 · 4 comments · Fixed by #47
Closed

Animal names for anonymous users #35

anibalsolon opened this issue Feb 4, 2021 · 4 comments · Fixed by #47

Comments

@anibalsolon
Copy link

anibalsolon commented Feb 4, 2021

Suggestion by @xgui3783 !

What is the current behaviour?

In the chat (and possibly other places), users that are not logged in are shown as 'undefined'.

What is the expected or desired behavior?

Show animal names! 🙆🏻‍♂️ 💥

@xgui3783
Copy link

xgui3783 commented Feb 5, 2021

How it started:

Undefined has entered

How it's going to be going:

The mischievous kangaroo had entered

@r03ert0
Copy link
Member

r03ert0 commented Feb 5, 2021

In BrainBox at the moment anonymous users get a 'u' name (see picture). The whole chat needs an overhaul, and the code should be common for brainbox and microdraw (same for the 'project' workflow). I'd be all for having animal names everywhere! With animal avatars!

@xgui3783
Copy link

xgui3783 commented Feb 5, 2021

hmm sounds like (at least the chat box) can be extracted into its own component/module/repository ?

I understand a portion microdraw is already written in vuejs, does it make sense to extract the chat functionality (both brainbox and microdraw) into its own repository, then bootstrap it the component in their respective parent applications.

so bugs such as #37 may only need to be fixed once, rather than twice (I know brainbox chat box may not have this issue, but just as an example)

@r03ert0
Copy link
Member

r03ert0 commented Feb 5, 2021

that would be awesome!
the only particularity of the chat - that's implemented in brainbox but not in microdraw yet - is that you can click on a person's name to navigate to the brain, view and slice where they are working. But I think it wouldn't be to difficult to come with an api for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants