layout space could be improved in default mode (PR #342) #375
Comments
ntraut
changed the title
|
maybe the chat could be closed by default when the window is so small? It could be then open by default in full screen mode
…On Oct 7 2023, at 12:39 pm, Nicolas Traut ***@***.***> wrote:
Thank you for your feedback.
Is it a [x] bug report or a [ ] feature request?
Current behaviour
If this is a bug, please explain how to reproduce the problem
Which tools did you use in which sequence?
none
Is the error concerning a text or a volume annotation?
no
Which label set has been used for the volume annotation (if applicable)?
not applicable
What is the type and resolution of your data? (Can you provide a link to your data?)
example data
Do not include sensitive information.
example data
Upload the browser error message if you are familiar with web developer tools.
I don't know if it's a bug or intended but layout repartition is not optimal in default mode. The annotation description takes a lot of space compared to the image, but it was already the case before. The problem is that the tools are now on top of the image, so it feels that too many things are on a restricted space when there is space around. Even after trying to move the tools at the bottom right, it is still above important parts of the image.
Expected behaviour
Something like before with the tools not on top of the image would be ideal, if not possible maybe the image could take more space so there is more unused space on the image where we can move the tools.
Version information (for bug reports)
Browser + version:
chrome latest
Your OS + version:
mac os latest
Paste the output of these commands:
node --version && npm --version
not using my local version
—
Reply to this email directly, view it on GitHub (#375), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AARUETD7HK7GHOCOBK4NHRLX6EWPJAVCNFSM6AAAAAA5W23OA6VHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTCMRZHEYTIOI).
You are receiving this because you are subscribed to this thread.
|
|
we could also have a display mode where only the slider and the axial, coronal and sagittal buttons are enabled (but the fix of collapsing the chat by default is easier)
…On Oct 7 2023, at 3:14 pm, roberto toro ***@***.***> wrote:
maybe the chat could be closed by default when the window is so small? It could be then open by default in full screen mode
On Oct 7 2023, at 12:39 pm, Nicolas Traut ***@***.***> wrote:
>
>
> Thank you for your feedback.
> Is it a [x] bug report or a [ ] feature request?
>
> Current behaviour
> If this is a bug, please explain how to reproduce the problem
> Which tools did you use in which sequence?
> none
>
> Is the error concerning a text or a volume annotation?
> no
>
> Which label set has been used for the volume annotation (if applicable)?
> not applicable
>
> What is the type and resolution of your data? (Can you provide a link to your data?)
> example data
>
> Do not include sensitive information.
> example data
>
> Upload the browser error message if you are familiar with web developer tools.
>
>
>
>
> I don't know if it's a bug or intended but layout repartition is not optimal in default mode. The annotation description takes a lot of space compared to the image, but it was already the case before. The problem is that the tools are now on top of the image, so it feels that too many things are on a restricted space when there is space around. Even after trying to move the tools at the bottom right, it is still above important parts of the image.
>
> Expected behaviour
> Something like before with the tools not on top of the image would be ideal, if not possible maybe the image could take more space so there is more unused space on the image where we can move the tools.
>
> Version information (for bug reports)
> Browser + version:
> chrome latest
>
> Your OS + version:
> mac os latest
>
> Paste the output of these commands:
>
>
>
> node --version && npm --version
> not using my local version
>
> —
> Reply to this email directly, view it on GitHub (#375), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AARUETD7HK7GHOCOBK4NHRLX6EWPJAVCNFSM6AAAAAA5W23OA6VHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZTCMRZHEYTIOI).
> You are receiving this because you are subscribed to this thread.
>
|
|
I remember we had a discussion in the PR where I was told not to bother with putting the tools at the bottom., which is what I had started doing.I can also hide the chat by default in MRI mode, or change the display mode as Roberto suggested, whatever works best for you. |
|
Yes, don't bother putting the tools at the bottom (it would make it more difficult to embed microdraw in another webpage)
…On Oct 7 2023, at 5:22 pm, denishov ***@***.***> wrote:
I remember we had a discussion in the PR where I was told not to bother with putting the tools at the bottom., which is what I had started doing.I can also hide the chat by default in MRI mode, whatever works best for you.
—
Reply to this email directly, view it on GitHub (#375 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AARUETGMJYV5SAQT5AEOEF3X6FXSDAVCNFSM6AAAAAA5W23OA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRG4ZTONJWGQ).
You are receiving this because you commented.
|
|
I guess that we need user feedback to know if people are annoyed or not by the new layout. That was one of the main reasons of setting the dev server (https://brainbox.connect-project.io/), but for now we haven't got a lot of feedback from it. Anyway we'll see after the merge... |
denishov
added a commit
to denishov/BrainBox
that referenced
this issue
Oct 10, 2023
|
Ah, I forgot about this one, sorry. I've disabled the chat by default in MRI mode, let me know if that works for you. |
|
I updated the dev server to reflect last changes. It will be important to see what users think once the PR will be merged. |
dhovart
pushed a commit
to denishov/BrainBox
that referenced
this issue
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thank you for your feedback.
Is it a [x] bug report or a [ ] feature request?
Current behaviour
none
no
not applicable
example data
example data
I don't know if it's a bug or intended but layout repartition is not optimal in default mode. The annotation description takes a lot of space compared to the image, but it was already the case before. The problem is that the tools are now on top of the image, so it feels that too many things are on a restricted space when there is space around. Even after trying to move the tools at the bottom right, it is still above important parts of the image.
Expected behaviour
Something like before with the tools not on top of the image would be ideal, if not possible maybe the image could take more space so there is more unused space on the image where we can move the tools.
Version information (for bug reports)
chrome latest
mac os latest
not using my local version
The text was updated successfully, but these errors were encountered: