-
Notifications
You must be signed in to change notification settings - Fork 52
implement ui build pipeline and complete workflows #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Build Artifacts Available |
📦 Build Artifacts Available |
🧹 The live preview for this PR has been removed. |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any issues. I do wonder if you could reduce the redundancy a bit, though.
I looked into composite actions a little bit but I'm not sure if they are a great option. It would be more a change in convention for the all of the actions, where if something is repeated enough we can make it into a composite action and then use that action. So we could look into that for repeated steps I suppose. I'm not sure if it would result in the exact same build output or cause any weird overhead. But for all of the quality related checks and such throughout all of the workflows I wonder if that is something people do to centralize logic. |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a complete UI build and deploy pipeline by updating environment configs and extending CI workflows with UI-specific jobs.
- Updated environment variable files for asset prefixes, base paths, and mock settings across all UI environments.
- Added UI unit, integration, and end-to-end test jobs, as well as lint/type/pre-commit checks to all relevant workflows.
- Introduced PR preview and cleanup workflows for automatic UI deployment on gh-pages.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/ui/.env.staging | Point staging to GitHub Pages release paths |
src/ui/.env.production | Point production to GitHub Pages latest release paths |
src/ui/.env.local | Disable local mock data flag |
src/ui/.env.example | Update example to disable mock data by default |
src/ui/.env.development | Point development to GitHub Pages dev paths |
.github/workflows/release.yml | Add UI test/build/publish jobs |
.github/workflows/release-candidate.yml | Add UI test/build/publish for release candidates |
.github/workflows/nightly.yml | Add UI test/build/publish for nightly releases |
.github/workflows/main.yml | Add UI lint, typing, pre-commit, tests, and deploy steps |
.github/workflows/development.yml | Add Node.js setup, UI tests, and PR preview workflow |
.github/workflows/development-cleanup.yml | New cleanup workflow for PR preview build artifacts |
Comments suppressed due to low confidence (3)
.github/workflows/release-candidate.yml:273
- The ASSET_PREFIX is missing the
/ui
segment, causing served assets to point to the wrong path. It should behttps://neuralmagic.github.io/guidellm/ui/release/latest
.
ASSET_PREFIX=https://neuralmagic.github.io/guidellm/release/latest
.github/workflows/main.yml:185
- The deploy-ui-build job should also depend on
ui-type-checks
to ensure type errors are caught before deployment.
needs: [ui-quality-checks, ui-precommit-checks, ui-unit-tests, ui-integration-tests]
.github/workflows/release.yml:94
- [nitpick] Multiple workflows repeat the Node.js setup and
npm ci
steps. Consider extracting these into a reusable workflow or composite action to reduce duplication.
- name: Set up Node.js 22
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
📦 Build Artifacts Available |
Builds would live at:
pr builds - neuralmagic.github.io/guidellm/ui/pr/12
dev - neuralmagic.github.io/guidellm/ui/dev
staging/release-candidate - neuralmagic.github.io/guidellm/ui/release/v1.0.0 or .../ui/release/latest
production/release - neuralmagic.github.io/guidellm/ui/v1.0.0 or .../ui/latest
PR builds will include mocked data, view example in comments below. All other builds currently will be blank slates, waiting to be pulled down and used to generate an html report.