Skip to content

implement ui build pipeline and complete workflows #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 10, 2025

Conversation

DaltheCow
Copy link
Contributor

@DaltheCow DaltheCow commented Jul 1, 2025

Builds would live at:
pr builds - neuralmagic.github.io/guidellm/ui/pr/12
dev - neuralmagic.github.io/guidellm/ui/dev
staging/release-candidate - neuralmagic.github.io/guidellm/ui/release/v1.0.0 or .../ui/release/latest
production/release - neuralmagic.github.io/guidellm/ui/v1.0.0 or .../ui/latest

PR builds will include mocked data, view example in comments below. All other builds currently will be blank slates, waiting to be pulled down and used to generate an html report.

@DaltheCow DaltheCow added the UI Front-end workstream label Jul 1, 2025

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16006308791/artifacts/3443086011.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16006308923/artifacts/3443086264.
They will be retained for up to 30 days.

Copy link

github-actions bot commented Jul 1, 2025

🧹 The live preview for this PR has been removed.

github-actions bot pushed a commit that referenced this pull request Jul 1, 2025

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16006490621/artifacts/3443150697.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16006490253/artifacts/3443151071.
They will be retained for up to 30 days.

github-actions bot pushed a commit that referenced this pull request Jul 1, 2025
jaredoconnell
jaredoconnell previously approved these changes Jul 8, 2025
Copy link
Collaborator

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues. I do wonder if you could reduce the redundancy a bit, though.

@DaltheCow
Copy link
Contributor Author

I don't see any issues. I do wonder if you could reduce the redundancy a bit, though.

I looked into composite actions a little bit but I'm not sure if they are a great option. It would be more a change in convention for the all of the actions, where if something is repeated enough we can make it into a composite action and then use that action. So we could look into that for repeated steps I suppose. I'm not sure if it would result in the exact same build output or cause any weird overhead. But for all of the quality related checks and such throughout all of the workflows I wonder if that is something people do to centralize logic.

Base automatically changed from migrate-to-flat-eslint-config to main July 10, 2025 13:02
@markurtz markurtz dismissed jaredoconnell’s stale review July 10, 2025 13:02

The base branch was changed.

@markurtz markurtz requested review from markurtz and Copilot July 10, 2025 13:03
Copilot

This comment was marked as outdated.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16197451336/artifacts/3504945983.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16197451919/artifacts/3504946869.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16197480909/artifacts/3504958265.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16197480604/artifacts/3504958885.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16197535067/artifacts/3504980924.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16197535462/artifacts/3504981124.
They will be retained for up to 30 days.

github-actions bot pushed a commit that referenced this pull request Jul 10, 2025

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16197709599/artifacts/3505047082.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16198183655/artifacts/3505226768.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16198183352/artifacts/3505227779.
They will be retained for up to 30 days.

github-actions bot pushed a commit that referenced this pull request Jul 10, 2025

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16198257656/artifacts/3505255722.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16198387010/artifacts/3505304028.
They will be retained for up to 30 days.

@markurtz markurtz requested a review from Copilot July 10, 2025 15:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a complete UI build and deploy pipeline by updating environment configs and extending CI workflows with UI-specific jobs.

  • Updated environment variable files for asset prefixes, base paths, and mock settings across all UI environments.
  • Added UI unit, integration, and end-to-end test jobs, as well as lint/type/pre-commit checks to all relevant workflows.
  • Introduced PR preview and cleanup workflows for automatic UI deployment on gh-pages.

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/ui/.env.staging Point staging to GitHub Pages release paths
src/ui/.env.production Point production to GitHub Pages latest release paths
src/ui/.env.local Disable local mock data flag
src/ui/.env.example Update example to disable mock data by default
src/ui/.env.development Point development to GitHub Pages dev paths
.github/workflows/release.yml Add UI test/build/publish jobs
.github/workflows/release-candidate.yml Add UI test/build/publish for release candidates
.github/workflows/nightly.yml Add UI test/build/publish for nightly releases
.github/workflows/main.yml Add UI lint, typing, pre-commit, tests, and deploy steps
.github/workflows/development.yml Add Node.js setup, UI tests, and PR preview workflow
.github/workflows/development-cleanup.yml New cleanup workflow for PR preview build artifacts
Comments suppressed due to low confidence (3)

.github/workflows/release-candidate.yml:273

  • The ASSET_PREFIX is missing the /ui segment, causing served assets to point to the wrong path. It should be https://neuralmagic.github.io/guidellm/ui/release/latest.
          ASSET_PREFIX=https://neuralmagic.github.io/guidellm/release/latest

.github/workflows/main.yml:185

  • The deploy-ui-build job should also depend on ui-type-checks to ensure type errors are caught before deployment.
    needs: [ui-quality-checks, ui-precommit-checks, ui-unit-tests, ui-integration-tests]

.github/workflows/release.yml:94

  • [nitpick] Multiple workflows repeat the Node.js setup and npm ci steps. Consider extracting these into a reusable workflow or composite action to reduce duplication.
      - name: Set up Node.js 22

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16200190319/artifacts/3506015236.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16200347759/artifacts/3506077788.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16201145891/artifacts/3506406087.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16201487771/artifacts/3506540607.
They will be retained for up to 30 days.

github-actions bot pushed a commit that referenced this pull request Jul 10, 2025
@markurtz markurtz merged commit ddbae80 into main Jul 10, 2025
17 checks passed
@markurtz markurtz deleted the ui-build-pipeline-and-ci branch July 10, 2025 20:55
github-actions bot pushed a commit that referenced this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Front-end workstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants