Skip to content

Migrate eslint config #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2025
Merged

Migrate eslint config #214

merged 4 commits into from
Jul 10, 2025

Conversation

DaltheCow
Copy link
Contributor

No description provided.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16006159070/artifacts/3443031046.
They will be retained for up to 30 days.

@DaltheCow DaltheCow added the UI Front-end workstream label Jul 1, 2025

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16010610786/artifacts/3444602311.
They will be retained for up to 30 days.

@markurtz markurtz requested review from Copilot and markurtz and removed request for Copilot July 8, 2025 15:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR overhauls the project’s ESLint setup to the new Flat ESLint format with TypeScript-aware and Next.js plugins, adjusts TypeScript and test configuration, and applies related import cleanups and minor code tweaks across the codebase.

  • Migrated eslint.config.js to Flat ESLint with @typescript-eslint, @next/eslint-plugin-next, and Prettier integrations
  • Expanded tsconfig.test.json include patterns and updated environment files and scripts to align with lint and test changes
  • Cleaned up import orders, removed duplicate lines, and refactored small utilities (e.g., removed unnecessary async, cast event values)

Reviewed Changes

Copilot reviewed 34 out of 36 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tsconfig.test.json Broke out .ts and .tsx patterns, added test helper and mocks
eslint.config.js Switched to Flat ESLint config, restructured plugins and rules
package.json Updated lint script to auto-fix, adjusted dev dependencies
src/ui/lib/store/slices/benchmarks/benchmarks.api.ts Changed dispatch signature to any, added ESLint disable comment
README.md Removed detailed setup instructions; replaced with placeholder notice
Comments suppressed due to low confidence (2)

README.md:162

  • [nitpick] The README now only contains a placeholder and lacks essential setup and development instructions. Consider restoring or updating the usage guides to help contributors and users get started.
The UI is a WIP, check more recent PRs for the latest updates

tests/ui/unit/utils/interpolation.test.ts:39

  • [nitpick] The naming of expected and actual here is semantically reversed—expected holds the interpolated value and actual holds the reference. Consider renaming them (e.g., interpolated and reference) to improve clarity.
  const loopedValuesToTest: { expected: number; actual: number }[] = [];

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16195735865/artifacts/3504294744.
They will be retained for up to 30 days.

📦 Build Artifacts Available
The build artifacts (.whl and .tar.gz) have been successfully generated and are available for download: https://github.com/neuralmagic/guidellm/actions/runs/16195794139/artifacts/3504316071.
They will be retained for up to 30 days.

@markurtz markurtz merged commit 227f170 into main Jul 10, 2025
16 checks passed
@markurtz markurtz deleted the migrate-to-flat-eslint-config branch July 10, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Front-end workstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants