-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User controlled phonenumbers, I don't get it. #165
Comments
In this plugin the 2nd factor phone number is managed like a credential. It can only be changed after logging in in Keycloak. It should therefore have the same security as a TOTP shared secret. However, the transport of SMS is obviously less secure. If you synchronize the phone number via LDAP and the attribute is writable somewhere else w/o entering a second factor, then this is obviously a loophole in the implementation. But I'm not sure if there is a native Keycloak way to synchronize a phone number attribute into a credential. |
I do understand the implementation from er service providers perspective, where the user is responsible for their own security. This extension (https://github.com/dasniko/keycloak-2fa-sms-authenticator) uses the mobile-number attribute for the SMS OTP, I guess I'll keep looking for something that can use a custom readonly-attribute. |
IMHO this depends on your threat model and the way you create accounts. If you have registration enabled in your Keycloak server, you can use the enforce-mfa plugin to force users to immediately set up a second factor. If you have the phone number available before the first sign in, then enforcing MFA with the phone number is obviously an advantage. But that is not possible in all cases. |
Oh, i must have missed something in the docs. I didn't think the extension could use predefined numbers. Thank you. |
Hi.
I'm looking into this plugin for 2fa OTP (obviously)
We have implemented security to avoid users having the ability to change their mobile-number in Active Directory (LDAP). This is done by moving the number to a LDAP-property that MSExchange cannot write to.
A users mobile-number can be changed via Microsoft Exchange by the user, which is a complete blunder in my eyes (exchange doesn't support 2FA) - so, an attacker could change the number, via Exchange Webmail (via username+password) and after that, have SMS-based OTP access.
I would really love to understand why user-managed mobile numbers (which I think, from reading here, is what this addon uses) can be secure. The second factor would be that we know that the number is the right one.
I'm not bashing, I'm just trying to understand why this implementation is considered secure (I must be missing something).
The text was updated successfully, but these errors were encountered: