From 17a88a649bd28fb82528215986b2930dcb9c1953 Mon Sep 17 00:00:00 2001 From: David de Boer Date: Tue, 17 Sep 2024 14:19:48 +0200 Subject: [PATCH] feat: Identity datasets by their URI * Consistently identify variants with hash (#) instead of slash (/). BREAKING CHANGE: terminology sources are no longer identifier by their distribution URI. Keep BC by still allowing the distribution URI to be used when searching. However, the sources query now returns source instead of distribution URIs. --- jest.config.js | 4 ++-- .../catalog/datasets/aat-materials.jsonld | 2 +- .../catalog/datasets/aat-processes-and-techniques.jsonld | 2 +- .../catalog/datasets/aat-styles-and-periods.jsonld | 4 ++-- .../catalog/datasets/cht-materials.jsonld | 2 +- .../catalog/datasets/cht-styles-and-periods.jsonld | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/jest.config.js b/jest.config.js index 0f576682d..5a4c5b25a 100644 --- a/jest.config.js +++ b/jest.config.js @@ -10,8 +10,8 @@ export default { ], coverageThreshold: { global: { - lines: 91.39, - statements: 91.39, + lines: 91.4, + statements: 91.4, branches: 95.45, functions: 92.62, }, diff --git a/packages/network-of-terms-catalog/catalog/datasets/aat-materials.jsonld b/packages/network-of-terms-catalog/catalog/datasets/aat-materials.jsonld index d35dfe6de..ff1433cea 100644 --- a/packages/network-of-terms-catalog/catalog/datasets/aat-materials.jsonld +++ b/packages/network-of-terms-catalog/catalog/datasets/aat-materials.jsonld @@ -1,6 +1,6 @@ { "@context": "https://schema.org/docs/jsonldcontext.jsonld", - "@id": "http://vocab.getty.edu/aat/materials", + "@id": "http://vocab.getty.edu/aat#materials", "@type": "Dataset", "name": [ { diff --git a/packages/network-of-terms-catalog/catalog/datasets/aat-processes-and-techniques.jsonld b/packages/network-of-terms-catalog/catalog/datasets/aat-processes-and-techniques.jsonld index 4508ad800..638b8ebf0 100644 --- a/packages/network-of-terms-catalog/catalog/datasets/aat-processes-and-techniques.jsonld +++ b/packages/network-of-terms-catalog/catalog/datasets/aat-processes-and-techniques.jsonld @@ -1,6 +1,6 @@ { "@context": "https://schema.org/docs/jsonldcontext.jsonld", - "@id": "http://vocab.getty.edu/aat/processes-and-techniques", + "@id": "http://vocab.getty.edu/aat#processes-and-techniques", "@type": "Dataset", "name": [ { diff --git a/packages/network-of-terms-catalog/catalog/datasets/aat-styles-and-periods.jsonld b/packages/network-of-terms-catalog/catalog/datasets/aat-styles-and-periods.jsonld index 1a4e35314..6a2b55070 100644 --- a/packages/network-of-terms-catalog/catalog/datasets/aat-styles-and-periods.jsonld +++ b/packages/network-of-terms-catalog/catalog/datasets/aat-styles-and-periods.jsonld @@ -1,6 +1,6 @@ { "@context": "https://schema.org/docs/jsonldcontext.jsonld", - "@id": "http://vocab.getty.edu/aat/styles-and-periods", + "@id": "http://vocab.getty.edu/aat#styles-and-periods", "@type": "Dataset", "name": [ { @@ -20,7 +20,7 @@ }, { "@id": "https://data.cultureelerfgoed.nl/termennetwerk/onderwerpen/Stijlen" - } + } ], "creator": [ { diff --git a/packages/network-of-terms-catalog/catalog/datasets/cht-materials.jsonld b/packages/network-of-terms-catalog/catalog/datasets/cht-materials.jsonld index 568b3542a..7b11577ac 100644 --- a/packages/network-of-terms-catalog/catalog/datasets/cht-materials.jsonld +++ b/packages/network-of-terms-catalog/catalog/datasets/cht-materials.jsonld @@ -1,6 +1,6 @@ { "@context": "https://schema.org/docs/jsonldcontext.jsonld", - "@id": "https://data.cultureelerfgoed.nl/term/id/cht/materials", + "@id": "https://data.cultureelerfgoed.nl/term/id/cht#materials", "@type": "Dataset", "name": [ { diff --git a/packages/network-of-terms-catalog/catalog/datasets/cht-styles-and-periods.jsonld b/packages/network-of-terms-catalog/catalog/datasets/cht-styles-and-periods.jsonld index 62bb1dba2..f52e21b68 100644 --- a/packages/network-of-terms-catalog/catalog/datasets/cht-styles-and-periods.jsonld +++ b/packages/network-of-terms-catalog/catalog/datasets/cht-styles-and-periods.jsonld @@ -1,6 +1,6 @@ { "@context": "https://schema.org/docs/jsonldcontext.jsonld", - "@id": "https://data.cultureelerfgoed.nl/term/id/cht/styles-and-periodes", + "@id": "https://data.cultureelerfgoed.nl/term/id/cht#styles-and-periodes", "@type": "Dataset", "name": [ {