Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmitterConfig: add support for single quote/double quote #169

Open
ghost opened this issue Jun 8, 2018 · 3 comments
Open

EmitterConfig: add support for single quote/double quote #169

ghost opened this issue Jun 8, 2018 · 3 comments

Comments

@ghost
Copy link

ghost commented Jun 8, 2018

Hi,

While reading EmitterConfig's docs of version 0.8.0, I think it doesn't support single quote/double quote yet. May I ask if you could add that support?

Or if you agree, I will try to find some time to code and send a PR for you to review.

Thank you,

@netvl
Copy link
Owner

netvl commented Jul 14, 2018

Hi,

If you want, you can send a PR. A new implementation of the parser/emitter infrastructure is in the works, which would cover this use case as well (but unfortunately I can't give any estimates about when it is done).

@ghost
Copy link
Author

ghost commented Jul 15, 2018

@netvl

Thanks for your reply. I was the one who filed this issue. Sometimes I deleted my GitHub account and registered another one (it's personal reason, I'm very sorry for that).

I think this is a simple feature, so if you're already implementing it, it's better to let you do so. Please close the issue as you see fit.

And thank you very much for your hard work.

@mickvangelderen
Copy link

I'm also looking for this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants