Skip to content

Commit 21c653e

Browse files
committed
fixed PHPStan errors
1 parent 100b76a commit 21c653e

2 files changed

Lines changed: 8 additions & 19 deletions

File tree

phpstan.neon

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
parameters:
2-
level: 7
2+
level: 8
33

44
paths:
55
- src
@@ -17,14 +17,3 @@ parameters:
1717
count: 1
1818
path: src/RobotLoader/RobotLoader.php
1919

20-
-
21-
message: '#^Unreachable statement \- code above always terminates\.$#'
22-
identifier: deadCode.unreachable
23-
count: 1
24-
path: src/RobotLoader/RobotLoader.php
25-
26-
-
27-
message: '#^Variable \$prevFile in isset\(\) always exists and is not nullable\.$#'
28-
identifier: isset.variable
29-
count: 2
30-
path: src/RobotLoader/RobotLoader.php

src/RobotLoader/RobotLoader.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,18 +97,18 @@ public function tryLoad(string $type): void
9797
return;
9898
}
9999

100-
[$file, $mtime] = $this->classes[$type] ?? null;
100+
[$file, $mtime] = $this->classes[$type] ?? [null, null];
101101

102102
if ($this->autoRebuild) {
103103
if (!$this->refreshed) {
104104
if (!$file || !is_file($file)) {
105105
$this->refreshClasses();
106-
[$file] = $this->classes[$type] ?? null;
106+
[$file] = $this->classes[$type] ?? [null, null];
107107
$this->needSave = true;
108108

109109
} elseif (filemtime($file) !== $mtime) {
110110
$this->updateFile($file);
111-
[$file] = $this->classes[$type] ?? null;
111+
[$file] = $this->classes[$type] ?? [null, null];
112112
$this->needSave = true;
113113
}
114114
}
@@ -285,11 +285,11 @@ private function updateFile(string $file): void
285285
$foundClasses = is_file($file) ? $this->scanPhp($file) : [];
286286

287287
foreach ($foundClasses as $class) {
288-
[$prevFile, $prevMtime] = $this->classes[$class] ?? null;
288+
[$prevFile, $prevMtime] = $this->classes[$class] ?? [null, null];
289289

290290
if (isset($prevFile) && @filemtime($prevFile) !== $prevMtime) { // @ file may not exist
291291
$this->updateFile($prevFile);
292-
[$prevFile] = $this->classes[$class] ?? null;
292+
[$prevFile] = $this->classes[$class] ?? [null, null];
293293
}
294294

295295
if (isset($prevFile)) {
@@ -485,13 +485,13 @@ private function acquireLock(string $file, int $mode)
485485
{
486486
$handle = @fopen($file, 'w'); // @ is escalated to exception
487487
if (!$handle) {
488-
throw new \RuntimeException(sprintf("Unable to create file '%s'. %s", $file, error_get_last()['message']));
488+
throw new \RuntimeException(sprintf("Unable to create file '%s'. %s", $file, error_get_last()['message'] ?? ''));
489489
} elseif (!@flock($handle, $mode)) { // @ is escalated to exception
490490
throw new \RuntimeException(sprintf(
491491
"Unable to acquire %s lock on file '%s'. %s",
492492
$mode & LOCK_EX ? 'exclusive' : 'shared',
493493
$file,
494-
error_get_last()['message'],
494+
error_get_last()['message'] ?? '',
495495
));
496496
}
497497

0 commit comments

Comments
 (0)