Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CSW Policy generation by outsourcing the Hostnames into Patternsets #545

Open
progS1m opened this issue Jul 20, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@progS1m
Copy link

progS1m commented Jul 20, 2022

Is your feature request related to a problem? Please describe.
If you have a huge list of hosts inside one Ingress for example to server multiple Top-Level-Domains, there is a max limit as of the policy length has a fixed size limit.

The policy gets with each host longer until you exceed a limit:

(HTTP.REQ.HOSTNAME.SERVER.EQ("www.booksample.ca")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.at")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.be")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.ch")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.co.uk")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.com")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.com.au")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.cz")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.de")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.es")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.fi")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.fr")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.hr")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.ie")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.in")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.it")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.nl")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.no")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.se")||HTTP.REQ.HOSTNAME.SERVER.EQ("partners.sampleusa.com")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.pt")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.dk")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.ee")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.pl")||HTTP.REQ.HOSTNAME.SERVER.EQ("www.sample.ru"))&&(HTTP.REQ.URL.PATH.SET_TEXT_MODE(IGNORECASE).STARTSWITH("/mypath"))

same applies if you have to many paths in a httproute etc. But at least there it is possible to work with wildcards so most of the time no problem.

Describe the solution you'd like
Improve the mechanism on how the policies are created by CIC. Suggestion store all domains into a patternset and reference it?

Describe alternatives you've considered
Split Ingress into multiple ingresses. Not the best, as it produces more policies.

@apoorvak-citrix apoorvak-citrix added the enhancement New feature or request label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants