Updating response for /claims 204 response (#193)

bearcherian · mraerino · commit bd366778111c · 2019-11-04T13:17:46.000+01:00
When a 204 is sent, no content is allowed. But using `sendJSON` creates
a response body with empty content and a "Content-Type" header. This
sets the status as 204, but returns no content as the spec requires.
diff --git a/api/order.go b/api/order.go
@@ -145,7 +145,8 @@ func (a *API) ClaimOrders(w http.ResponseWriter, r *http.Request) error {
 	}
 
 	log.Info("Finished updating")
-	return sendJSON(w, http.StatusNoContent, "")
+	w.WriteHeader(http.StatusNoContent)
+	return nil
 }
 
 // ReceiptView renders an HTML receipt for an order

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,8 @@ func (a API) ClaimOrders(w http.ResponseWriter, r http.Request) error {`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`log.Info("Finished updating")`
`148`		`- return sendJSON(w, http.StatusNoContent, "")`
	`148`	`+ w.WriteHeader(http.StatusNoContent)`
	`149`	`+ return nil`
`149`	`150`	`}`
`150`	`151`
`151`	`152`	`// ReceiptView renders an HTML receipt for an order`