fix: await zipFunctions() in functions build (#7180)

* fix: fully wait for build in `functions:build` cmd

* build: fix suppressed eslint errors

Author: serhalp

eslint_temporary_suppressions.js

@@ -212,14 +212,6 @@ export default [
       '@typescript-eslint/no-unsafe-return': 'off',
     },
   },
-  {
-    files: ['src/commands/functions/functions-build.ts'],
-    rules: {
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-unsafe-argument': 'off',
-      '@typescript-eslint/no-floating-promises': 'off',
-    },
-  },
   {
     files: ['src/commands/functions/functions-create.ts'],
     rules: {

src/commands/functions/functions-build.ts

@@ -10,7 +10,9 @@ import type BaseCommand from '../base-command.js'
 export const functionsBuild = async (options: OptionValues, command: BaseCommand) => {
   const { config } = command.netlify
 
-  const src = options.src || config.build.functionsSource
+  const src =
+    ('src' in options && typeof options.src === 'string' && options.src.trim().length > 0 ? options.src : null) ??
+    config.build.functionsSource
   const dst = getFunctionsDir({ options, config })
 
   if (src === dst) {
@@ -27,13 +29,13 @@ export const functionsBuild = async (options: OptionValues, command: BaseCommand
       log(
         `${NETLIFYDEVERR} Error: You must specify a destination functions folder with a --functions flag or a functions field in your config`,
       )
-    exit(1)
+    return exit(1)
   }
 
   await mkdir(dst, { recursive: true })
 
   log(`${NETLIFYDEVLOG} Building functions`)
 
-  zipFunctions(src, dst)
+  await zipFunctions(src, dst)
   log(`${NETLIFYDEVLOG} Functions built to `, dst)
 }

src/utils/functions/functions.ts

@@ -10,6 +10,8 @@ import type { NormalizedCachedConfigConfig } from '../command-helpers.js'
 export const INTERNAL_FUNCTIONS_FOLDER = 'functions-internal'
 export const SERVE_FUNCTIONS_FOLDER = 'functions-serve'
 
+const isNonEmptyString = (s: unknown): s is string => typeof s === 'string' && s.length > 0
+
 /**
  * retrieves the function directory out of the flags or config
  */
@@ -22,7 +24,11 @@ export const getFunctionsDir = (
     options: OptionValues
   },
   defaultValue?: string,
-) => options.functions || config.dev?.functions || config.functionsDirectory || defaultValue
+): string | undefined =>
+  ('functions' in options && isNonEmptyString(options.functions) ? options.functions : null) ??
+  (isNonEmptyString(config.dev?.functions) ? config.dev.functions : null) ??
+  (isNonEmptyString(config.functionsDirectory) ? config.functionsDirectory : null) ??
+  defaultValue
 
 export const getFunctionsManifestPath = async ({ base, packagePath = '' }: { base: string; packagePath?: string }) => {
   const path = resolve(base, packagePath, getPathInProject(['functions', 'manifest.json']))