Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mapping a field with wrong ID #49

Merged
merged 2 commits into from
Oct 4, 2017
Merged

Fix mapping a field with wrong ID #49

merged 2 commits into from
Oct 4, 2017

Conversation

pspanja
Copy link
Member

@pspanja pspanja commented Oct 4, 2017 •
edited
Loading

This PR fixes #48

In master branch, mapping a Site API field object takes the wrong ID. The mapper uses field definition ID instead of the field ID.

https://github.com/netgen/ezplatform-site-api/blob/master/lib/Core/Site/DomainObjectMapper.php#L179-L180

TODO:

  • Add test
  • Fix

@pspanja pspanja requested a review from emodric October 4, 2017 09:15
@pspanja pspanja merged commit 1a230ab into master Oct 4, 2017
@pspanja pspanja deleted the fix_field_id branch October 4, 2017 09:19
@emodric emodric mentioned this pull request Oct 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emodric emodric emodric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mapping a field takes the wrong ID
2 participants
@pspanja @emodric