Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapping a field takes the wrong ID #48

Closed
emodric opened this issue Oct 4, 2017 · 1 comment · Fixed by #49
Closed

Mapping a field takes the wrong ID #48

emodric opened this issue Oct 4, 2017 · 1 comment · Fixed by #49
Assignees
@pspanja

Comments

@emodric
Copy link
Member

emodric commented Oct 4, 2017 •
edited by pspanja
Loading

In master branch, mapping a Site API field object takes the wrong ID. The mapper uses field definition ID instead of the field ID.

https://github.com/netgen/ezplatform-site-api/blob/master/lib/Core/Site/DomainObjectMapper.php#L179-L180
@pspanja pspanja self-assigned this Oct 4, 2017
@pspanja pspanja mentioned this issue Oct 4, 2017
Merged
2 tasks
@pspanja
Copy link
Member

pspanja commented Oct 4, 2017

Thanks @emodric!

@pspanja pspanja mentioned this issue Oct 4, 2017
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pspanja pspanja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mapping a field with wrong ID netgen/ezplatform-site-api
2 participants
@emodric @pspanja