Kernel v3 compatibility #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @wizhippo |
emodric
reviewed
Oct 4, 2019
emodric
reviewed
Oct 4, 2019
emodric
approved these changes
Oct 4, 2019
|
media-site/ezplatform3 is closer to working now with these changes. Thanks. |
|
@wizhippo What does not work with |
|
I may have some dep conflicts. SncRedisBundle is complaining about empty client config and building the ezplatform assets is complaining. I've spun up a media site using the doc/docker. Working now after a composer update. |
Hm... I thought I fixed that in the repo. Will check again.
Complaining how? |
It's all good now thanks |
|
Updated for ezsystems/ezpublish-kernel#2808 in bf2ad5f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135
Made compatible with v3 of the kernel:
MatcherFactorydepended on a class that was made final, see MatcherFactory Broken with ezplatform v3 #135RepositoryFactorygot a new parameter