minor fix - linter

Author: crn4

signal/peer/peer.go

@@ -140,7 +140,7 @@ func (registry *Registry) RegisterPool(peer *Peer) error {
 			log.Tracef("peer [%s] is already registered [new streamID %d, previous StreamID %d]. Will override stream.",
 				peer.Id, peer.StreamID, pp.StreamID)
 			if swapped := registry.Peers.CompareAndSwap(peer.Id, pp, peer); !swapped {
-				registry.RegisterPool(peer)
+				return registry.RegisterPool(peer)
 			}
 			pp.Cancel()
 		}

signal/peer/peer_test.go

@@ -130,7 +130,7 @@ func TestRegistry_MultipleRegister_Concurrency(t *testing.T) {
 			defer wg.Done()
 
 			peer := NewPeerPool(peerID, nil, cancel)
-			registry.RegisterPool(peer)
+			_ = registry.RegisterPool(peer)
 			ids <- peer.StreamID
 		}(i)
 	}
@@ -145,6 +145,8 @@ func TestRegistry_MultipleRegister_Concurrency(t *testing.T) {
 	peer, ok := registry.Get(peerID)
 	require.True(t, ok, "expected peer to be registered")
 	require.Equal(t, maxId, peer.StreamID, "expected the highest StreamID to be registered")
+
+	cancel()
 }
 
 func Benchmark_MultipleRegister_Concurrency(b *testing.B) {
@@ -183,12 +185,13 @@ func Benchmark_MultipleRegister_Concurrency(b *testing.B) {
 					defer wg.Done()
 
 					peer := NewPeerPool(peerID, nil, cancel)
-					registry.RegisterPool(peer)
+					_ = registry.RegisterPool(peer)
 				}(i)
 			}
 			wg.Wait()
 		}
 	})
+	cancel()
 }
 
 func TestRegistry_MultipleDeregister_Concurrency(t *testing.T) {
@@ -210,7 +213,7 @@ func TestRegistry_MultipleDeregister_Concurrency(t *testing.T) {
 			defer wg.Done()
 
 			peer := NewPeerPool(peerID, nil, cancel)
-			registry.RegisterPool(peer)
+			_ = registry.RegisterPool(peer)
 			ids <- peer.StreamID
 			registry.DeregisterPool(peer)
 		}(i)
@@ -225,6 +228,7 @@ func TestRegistry_MultipleDeregister_Concurrency(t *testing.T) {
 
 	_, ok := registry.Get(peerID)
 	require.False(t, ok, "expected peer to be deregistered")
+	cancel()
 }
 
 func Benchmark_MultipleDeregister_Concurrency(b *testing.B) {
@@ -265,7 +269,7 @@ func Benchmark_MultipleDeregister_Concurrency(b *testing.B) {
 					defer wg.Done()
 
 					peer := NewPeerPool(peerID, nil, cancel)
-					registry.RegisterPool(peer)
+					_ = registry.RegisterPool(peer)
 					time.Sleep(time.Nanosecond)
 					registry.DeregisterPool(peer)
 				}(i)

signal/server/signal_test.go

@@ -17,6 +17,7 @@ import (
 	"google.golang.org/grpc/status"
 
 	log "github.com/sirupsen/logrus"
+	"github.com/stretchr/testify/require"
 
 	"github.com/netbirdio/netbird/signal/peer"
 	"github.com/netbirdio/netbird/signal/proto"
@@ -116,7 +117,8 @@ func BenchmarkConnectStream(b *testing.B) {
 		}()
 
 		b.StartTimer()
-		fn(mockStream)
+		err := fn(mockStream)
+		require.NoError(b, err, "ConnectStream should not return an error")
 	}
 	b.Run("old", func(b *testing.B) {
 		for i := 0; i < b.N; i++ {