Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for secondary IP under floating SVI #105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

robvand
Copy link
Contributor

@robvand robvand commented Jul 3, 2024

Added ip_shared as attribute for local.floating_interfaces and l3extIp_floating resource. Resolves #104

@andbyrne andbyrne self-requested a review July 11, 2024 07:38
versions.tf Outdated Show resolved Hide resolved
modules/terraform-aci-l3out/versions.tf Outdated Show resolved Hide resolved
modules/terraform-aci-l3out-interface-profile/versions.tf Outdated Show resolved Hide resolved
@danischm
Copy link
Member

Please merge the latest commits from main, which should fix the CI workflow.

Copy link
Contributor

@andbyrne andbyrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andbyrne
Copy link
Contributor

You'll first need to merge the upstream branch to ensure you don't undo some of the version changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Support for secondary IP on floating SVI
3 participants